fix(android): correct ScrollView.contentOffset units

[garymathews]

• Correctly handle ScrollView.contentOffset units

TEST CASE

• Scroll part way into green and click red, this should scroll back to the top
• Scroll part way into blue and click green, this should scroll to green
• Clicking blue should scroll 100dp into red

const win = Ti.UI.createWindow();
const scrollView = Ti.UI.createScrollView({
    layout: 'vertical',
    backgroundColor: 'white',
    width: Ti.UI.FILL,
    height: Ti.UI.FILL
});
const view_a = Ti.UI.createView({
    backgroundColor: 'red',
    width: '100%',
    height: '100%'
});
const view_b = Ti.UI.createView({
    backgroundColor: 'green',
    width: '100%',
    height: '100%'
});
const view_c = Ti.UI.createView({
    backgroundColor: 'blue',
    width: '100%',
    height: '100%'
});

view_a.addEventListener('click', e => {
    console.log(`previous contentOffset: ${JSON.stringify(scrollView.contentOffset)}`);
    scrollView.contentOffset = {
        x: 0,
        y: 0
    };
    console.log(`new contentOffset: ${JSON.stringify(scrollView.contentOffset)}`);
});

view_b.addEventListener('click', e => {
    console.log(`previous contentOffset: ${JSON.stringify(scrollView.contentOffset)}`);
    scrollView.contentOffset = {
        x: 0,
        y: view_a.rect.height
    };
    console.log(`new contentOffset: ${JSON.stringify(scrollView.contentOffset)}`);
});

view_c.addEventListener('click', e => {
    console.log(`previous contentOffset: ${JSON.stringify(scrollView.contentOffset)}`);
    scrollView.contentOffset = {
        x: 0,
        y: '100dp'
    };
    console.log(`new contentOffset: ${JSON.stringify(scrollView.contentOffset)}`);
});

scrollView.add([
    view_a,
    view_b,
    view_c
]);

win.add(scrollView);
win.open();

JIRA Ticket
#12608

[build]

	Fails
🚫	Tests have failed, see below for more information.

	Messages
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	❌ 9 tests have failed There are 9 tests failing and 957 skipped out of 15323 total tests.

Tests:

Classname	Name	Time	Error
android.emulator.Titanium.UI.NavigationWindow	basic open/close navigation (5.0.2)	10.011	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.Window	window_navigation (5.0.2)	30.007	Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.ScrollView	contentOffset (5.0.2)	1.08	Error: Uncaught Uncaught AssertionError
android.emulator.Titanium.UI.View	"after all" hook for "rgba fallback" (5.0.2)	23.086	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View	"after each" hook for "getOrCreateView() should always return a View" (5.0.2)	12.984	Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.ScrollView	contentOffset (14.4.0)	0.117	Error: Uncaught expected 2 to equal 10
ios.iphone.Titanium.UI.ScrollView	contentOffset (14.4.0)	0.114	Error: Uncaught expected 2 to equal 10
ios.macos.Titanium.Filesystem.File	#getDirectoryListing() can access resource directory files (10.15.7)	2.263	Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js) run@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12615/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9154:22 processImmediateQueue@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12615/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9217:18 drainQueues@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12615/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9194:52
ios.macos.Titanium.UI.ScrollView	contentOffset (10.15.7)	0.199	Error: Uncaught expected 5 to equal 10

Generated by 🚫 dangerJS against 5fd2246

[jquick-axway]

CR: Pass

[drauggres]

Actually, there is no need to call it here. We will call setContentOffset(int x, int y) later from onScrollChanged which is triggered by the scrollTo on the next line.

[lokeshchdhry]

FR Passed.