Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_0_X] fix(android): correct ScrollView.contentOffset units #12854

Merged
merged 3 commits into from
May 27, 2021

Conversation

build
Copy link
Contributor

@build build commented May 27, 2021

Backport of #12615.
See that PR for full details.

@build
Copy link
Contributor Author

build commented May 27, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 8 tests have failed There are 8 tests failing and 962 skipped out of 16078 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.Network.HTTPClient#timeoutForResource (14.4.0)0.001
Error: onload shouldn't fire. Resource request timeout should reach before transferring entire resource.
file:///Users/build/Library/Developer/CoreSimulator/Devices/8004FEFB-9C69-45DD-8F64-47B0C61BCF24/data/Containers/Bundle/Application/0E3EC5F9-698E-4A40-8099-4B9BB2CB030B/mocha.app/ti.network.httpclient.test.js:810:40
ios.ipad.Titanium.Network.HTTPClientresponseHeaders (14.4.0)60.002
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.Network.HTTPClientTIMOB-23214 (14.4.0)60
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.ScrollViewcontentOffset (14.4.0)0.113
Error: Uncaught expected 2 to equal 10
ios.iphone.Titanium.UI.ScrollViewcontentOffset (14.4.0)0.109
Error: Uncaught expected 2 to equal 10
ios.macos.Titanium.Network.HTTPClient#timeoutForResource (10.15.5)0.002
Error: onload shouldn't fire. Resource request timeout should reach before transferring entire resource.
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12854/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.network.httpclient.test.js:810:40
ios.macos.Titanium.Network.HTTPClientresponseHeaders (10.15.5)60.061
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.ScrollViewcontentOffset (10.15.5)0.239
Error: Uncaught expected 9 to equal 10

Generated by 🚫 dangerJS against 69671df

@sgtcoolguy sgtcoolguy merged commit 5759752 into tidev:10_0_X May 27, 2021
@sgtcoolguy sgtcoolguy deleted the backport-12615-to-10_0_X branch May 27, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants