Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): retain isWhatever query methods on MenuItem/Sound, mark deprecated #12692

Merged
merged 10 commits into from Apr 8, 2021

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-28407

Optional Description:
Follow-on to #12677

  • Add back, but deprecate:

    • Ti.Android.MenuItem.isActionViewExpanded
    • Ti.Android.MenuItem.isCheckable
    • Ti.Android.MenuItem.isChecked
    • Ti.Android.MenuItem.isEnabled
    • Ti.Android.MenuItem.isVisible
    • Ti.Media.Sound.isLooping (added back to Android, it's cross-platform now)
    • Ti.Media.Sound.isPlaying (added back to Android, it's cross-platform now)
    • Ti.Media.Sound.isPaused (added back to Android, it's cross-platform now)
  • Deprecate:

    • Ti.UI.Tab.setWindow

@sgtcoolguy sgtcoolguy added android docs backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Apr 6, 2021
@build build added this to the 10.1.0 milestone Apr 6, 2021
@build build requested review from a team April 6, 2021 18:31
@build
Copy link
Contributor

build commented Apr 6, 2021

Warnings
⚠️

Commit 5293caad3be841c4a242d572948e61c3d35e7020 has a message "build(deps-dev): bump core-js from 3.10.0 to 3.10.1

Bumps core-js from 3.10.0 to 3.10.1.

Signed-off-by: dependabot-preview[bot] support@dependabot.com" giving 1 errors:

  • body's lines must not be longer than 100 characters
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 14628 tests are passing.
(There are 965 skipped tests not included in that total)

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS against 806e7cf

@jquick-axway
Copy link
Contributor

FYI: I already changed kitchensink-v2 to use Ti.Media.Sound.is* properties.
tidev/kitchensink-v2#56

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I can do an FR tomorrow if needed

@ewanharris
Copy link
Collaborator

@sgtcoolguy I overlooked that Ti.UI.Tab.setWindow is removed on iOS, but exists on Android. So I think the docs need to be amended to state that?

@sgtcoolguy
Copy link
Contributor Author

@ewanharris Good catch! Trying to use setWindow on iOS causes an Error. I have pushed a fix by implementing it in our common JS extension layer for iOS that would be pretty easy to remove once we kill the method off.

dependabot-preview bot and others added 4 commits April 8, 2021 12:53
…read

most likely scenario is failure to decrypt. We need to avoid opening a dialog
because that will prevent the 'Security Violation' error dialog that the
decryption code will pop.

Fixes TIMOB-28408
@build build added ios and removed needs tests 🚨 labels Apr 8, 2021
@sgtcoolguy sgtcoolguy merged commit d73699f into tidev:master Apr 8, 2021
@sgtcoolguy sgtcoolguy deleted the deprecations-is-query branch April 8, 2021 19:34
@build
Copy link
Contributor

build commented Apr 8, 2021

The backport to 10_0_X failed:

The process 'git' failed with exit code 128

Check the run for full details
To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12692-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/3c38ea52f7676ed5da2e6650c688a9ae279458de.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/502ce2ccf1f71340da43dcc5a1eb4e0f4e35f26f.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/8a741d7c9fd7307d9140b3a50d947907cb506065.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/20f0d6311e7b8c7c34e5c1570d49b184419dfebd.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/3c7321de6b77974e7fba9c660cf74f92e725615d.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/a1a9b25a651044626de815e9cdfeac159a00f47e.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/5293caad3be841c4a242d572948e61c3d35e7020.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/63088889a72d37f3aee726a3934ab8542f5d6376.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/1e55afe686d0b10049d75746fba92c362aed31a4.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/806e7cf91b383d9929a816a5e3d7f68a9d165a05.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12692-to-10_0_X

Then, create a pull request where the base branch is 10_0_X and the compare/head branch is backport-12692-to-10_0_X.

@ewanharris ewanharris removed 10_0_X backport failed backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants