New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): retain isWhatever query methods on MenuItem/Sound, mark deprecated #12692
Conversation
|
FYI: I already changed kitchensink-v2 to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I can do an FR tomorrow if needed
@sgtcoolguy I overlooked that |
@ewanharris Good catch! Trying to use |
bb91a2c
to
a1a9b25
Compare
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.10.0 to 3.10.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.10.1/packages/core-js) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…read most likely scenario is failure to decrypt. We need to avoid opening a dialog because that will prevent the 'Security Violation' error dialog that the decryption code will pop. Fixes TIMOB-28408
…rl property (tidev#12508) Fixes TIMOB-28217
29e2559
to
806e7cf
Compare
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12692-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/3c38ea52f7676ed5da2e6650c688a9ae279458de.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/502ce2ccf1f71340da43dcc5a1eb4e0f4e35f26f.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/8a741d7c9fd7307d9140b3a50d947907cb506065.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/20f0d6311e7b8c7c34e5c1570d49b184419dfebd.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/3c7321de6b77974e7fba9c660cf74f92e725615d.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/a1a9b25a651044626de815e9cdfeac159a00f47e.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/5293caad3be841c4a242d572948e61c3d35e7020.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/63088889a72d37f3aee726a3934ab8542f5d6376.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/1e55afe686d0b10049d75746fba92c362aed31a4.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/806e7cf91b383d9929a816a5e3d7f68a9d165a05.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12692-to-10_0_X Then, create a pull request where the |
JIRA: https://jira.appcelerator.org/browse/TIMOB-28407
Optional Description:
Follow-on to #12677
Add back, but deprecate:
Ti.Android.MenuItem.isActionViewExpanded
Ti.Android.MenuItem.isCheckable
Ti.Android.MenuItem.isChecked
Ti.Android.MenuItem.isEnabled
Ti.Android.MenuItem.isVisible
Ti.Media.Sound.isLooping
(added back to Android, it's cross-platform now)Ti.Media.Sound.isPlaying
(added back to Android, it's cross-platform now)Ti.Media.Sound.isPaused
(added back to Android, it's cross-platform now)Deprecate:
Ti.UI.Tab.setWindow