Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update for Titanium SDK 10.0.0 #56

Merged
merged 9 commits into from
May 18, 2021
Merged

chore: update for Titanium SDK 10.0.0 #56

merged 9 commits into from
May 18, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Feb 26, 2021 •
edited

Prerequisites:

  • Requires Titanium SDK 10.0.0.
  • Requires CLI 9.0.0 for <OptionBar/> support in Alloy. See: ALOY-1746

Shared Changes:

  • Updated app version to "8.0.0".
  • Disabled analytics.
  • Added a new "ButtonBar" window.
  • Added a new "OptionBar" window.
  • Rewritten "ti.identity" window. Supports passcode fallback.
  • Fixed layout in gradients window for narrow screens.
  • Fixed layout in clipboard window for narrow screens.
  • Removed getter/setter property methods in soundLocal.js script.

iOS Changes:

  • Modified plist to only support "Light" theme. (Currently has dark theming issues.)

Android Changes:

  • Modified to support dark/light (aka: night/day) theming.
  • Changed TabGroup to use bottom tab style with icons.
  • Added random color button to Activity Indicator window. (iOS already has it.)
  • Changed text fields to use material rounded borders with animated hint text.
  • Changed text areas to use material "filled" style.
  • Disabled Facebook analytics to prevent errors being logged when opening windows if ID isn't set.

Controls-Android-Light Controls-Android-Dark TextField-Android-Light
Gradients-Android-Light Gradients-Android-Dar

ewanharris
ewanharris approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. One comment but it's not a blocking issue for this PR

app/controllers/phone/identity.js Outdated Show resolved Hide resolved
@jquick-axway jquick-axway mentioned this pull request Feb 27, 2021
Merged
Topener
Topener approved these changes Mar 1, 2021
View reviewed changes
Copy link
Sponsor Contributor

@Topener Topener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny changes I'd implement, none blocking.

app/views/controls/views/gradients.xml
Comment on lines +6 to +11
<Label class="radiusLabel" id="startRadiusLabel" width="30%">Start Radius:</Label>
<Slider class="radiusSlider" id="startRadiusSlider" width="Ti.UI.FILL" onChange="updateGradient" />

<!-- End Radius -->
<Label class="radiusLabel" id="endRadiusLabel">End Radius:</Label>
<Slider class="radiusSlider" id="endRadiusSlider" onChange="updateGradient" />
<Label class="radiusLabel" id="endRadiusLabel" width="30%">End Radius:</Label>
<Slider class="radiusSlider" id="endRadiusSlider" value="100" width="Ti.UI.FILL" onChange="updateGradient" />
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, put these properties in tss since they're shared with 2 items, or in the last case have more than one item. We already have an ID.

Not blocking PR, but more a best practice.

tiapp.xml Outdated Show resolved Hide resolved
tiapp.xml Outdated Show resolved Hide resolved
@jquick-axway jquick-axway mentioned this pull request Apr 6, 2021
Merged
@ssjsamir ssjsamir self-requested a review April 23, 2021 15:34
ssjsamir
ssjsamir approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Looks good, using SDK Version 10.0.0.v20210420110412 on both iOS and Android.

@jquick-axway jquick-axway merged commit d89ae20 into tidev:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

@Topener Topener Topener approved these changes

@ewanharris ewanharris ewanharris approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @sgtcoolguy @Topener @ewanharris @ssjsamir