Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ScrollView setZoomScale()/setContentOffset() methods crash as of 10.0.0 #12788

Merged
merged 2 commits into from May 10, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28443

Summary:

  • This is a regression as of Titanium 10.0.0.
  • Calling Ti.UI.ScrollView methods setZoomScale() or setContentOffset() crash with function not found.
  • These methods are needed since they support a 2nd argument.

Test:

  1. Build and run the code shown in TIMOB-28443 on iOS.
  2. Double tap on the red square.
  3. Verify that square doubles in size with an animation.

@jquick-axway jquick-axway added ios bug backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 8, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone May 8, 2021
@build build requested a review from a team May 8, 2021 02:23
@build
Copy link
Contributor

build commented May 8, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 6 tests have failed There are 6 tests failing and 957 skipped out of 15270 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (5.0.2)10.04
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.Windowwindow_navigation (5.0.2)30.015
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)12.63
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.WebViewbeforeload (14.4.0)30.001
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebViewbeforeload (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.WebViewbeforeload (10.15.7)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 915f02f

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit e7c5ff3 into tidev:master May 10, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants