Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_0_X] fix(ios): ScrollView setZoomScale()/setContentOffset() methods crash as of 10.0.0 #12796

Merged
merged 1 commit into from
May 10, 2021

Conversation

build
Copy link
Contributor

@build build commented May 10, 2021

Backport of #12788.
See that PR for full details.

@build build added this to the 10.0.0 milestone May 10, 2021
@build build requested a review from a team May 10, 2021 18:47
@build
Copy link
Contributor Author

build commented May 10, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 6 tests have failed There are 6 tests failing and 689 skipped out of 12957 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.591
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.572
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4.0)0.497
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@2x.png')
    mismatched pixels. allowed: 14840, actual: 53921
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F959E99C-6F1B-47A7-AF0B-F86C187C3CCC/data/Containers/Bundle/Application/3913F57D-04F4-473A-9548-3E0B8AAA0FDB/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/F959E99C-6F1B-47A7-AF0B-F86C187C3CCC/data/Containers/Bundle/Application/3913F57D-04F4-473A-9548-3E0B8AAA0FDB/mocha.app/ti.ui.tableview.test.js:1811:28
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/F959E99C-6F1B-47A7-AF0B-F86C187C3CCC/data/Containers/Bundle/Application/3913F57D-04F4-473A-9548-3E0B8AAA0FDB/mocha.app/ti.main.js:8761:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/F959E99C-6F1B-47A7-AF0B-F86C187C3CCC/data/Containers/Bundle/Application/3913F57D-04F4-473A-9548-3E0B8AAA0FDB/mocha.app/ti.main.js:8824:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/F959E99C-6F1B-47A7-AF0B-F86C187C3CCC/data/Containers/Bundle/Application/3913F57D-04F4-473A-9548-3E0B8AAA0FDB/mocha.app/ti.main.js:8801:52
ios.ipad.Titanium.UI.WebViewbeforeload (14.4.0)30.001
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4.0)0.847
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@3x.png')
    mismatched pixels. allowed: 14840, actual: 200203
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/F5BB41A5-ED87-4D4E-935C-A9D443CD8D9C/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/F5BB41A5-ED87-4D4E-935C-A9D443CD8D9C/mocha.app/ti.ui.tableview.test.js:1811:28
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/F5BB41A5-ED87-4D4E-935C-A9D443CD8D9C/mocha.app/ti.main.js:8761:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/F5BB41A5-ED87-4D4E-935C-A9D443CD8D9C/mocha.app/ti.main.js:8824:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/C719D9C6-D0B2-44F4-A105-4951C0BAC799/data/Containers/Bundle/Application/F5BB41A5-ED87-4D4E-935C-A9D443CD8D9C/mocha.app/ti.main.js:8801:52
ios.iphone.Titanium.UI.WebViewbeforeload (14.4.0)30.001
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against fc26be6

@sgtcoolguy sgtcoolguy merged commit 8dcf5c8 into tidev:10_0_X May 10, 2021
@sgtcoolguy sgtcoolguy deleted the backport-12788-to-10_0_X branch May 10, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants