Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): hyperloop defineClass() crash #12829

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented May 21, 2021

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28458

Summary:

  • Regression as of Titanium 10.0.0.
  • Caused by removal of KrollBridge.require() method require by hyperloop here.
  • Also, the global.require function was removed in 10.0.0 which is needed by our core JS code here.

Test:

  1. Build and run hyperloop-examples for iOS.
  2. Go to every window in the app and verify they were as expected.

@jquick-axway jquick-axway added ios bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 21, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone May 21, 2021
@build build requested a review from a team May 21, 2021 04:01
@build
Copy link
Contributor

build commented May 21, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 738 skipped out of 11832 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.403
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.385
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.Viewanimate width/height from zero (10.15.5)10.122
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 0783c97

@ewanharris ewanharris merged commit 352b2db into tidev:master Jun 17, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants