Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build with SDK 10.0.1 #465

Merged
merged 6 commits into from
Aug 25, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jul 23, 2021

Summary:
Modified to build module with Titanium 10.0.1 since iOS minsdk is 10.0.0.

@build
Copy link

build commented Jul 23, 2021

Messages
📖

✅ All tests are passing
Nice one! All 292 tests are passing.
(There are 2 skipped tests not included in that total)

📖

💾 Here are the artifacts produced:

Generated by 🚫 dangerJS against fb81a19

@ewanharris
Copy link
Contributor

It appears that building the test app with 10.0.0.GA is causing the tests to not run. Will look into it today

@ewanharris
Copy link
Contributor

Issue looks to be fixed by tidev/titanium-sdk/pull/12829, bumping the SDK to 10.0.1.v20210723095034 should fix this

@jquick-axway jquick-axway added the WIP Work in progress label Jul 26, 2021
@jquick-axway jquick-axway removed the WIP Work in progress label Aug 3, 2021
@jquick-axway jquick-axway changed the title chore: build with SDK 10.0.0 chore: build with SDK 10.0.1 Aug 3, 2021
@jquick-axway
Copy link
Contributor Author

This PR isn't done yet. Need to do the following:

  • Bring back support for View.setLocation() method.
    • Building with Titanium 10.x.x wrongly turned this into a property, but we document it as a method only.
  • Change unit test for Snapshotter.setShowBuildings() to use documented Snapshotter.showBuildings property instead.

@hansemannn
Copy link
Contributor

hansemannn commented Aug 17, 2021

Would love to see this merged, soon! @jquick-axway Are the two issues you mentioned still open? Then I could take them over. But the setter vs method issue seems to be an SDK-related one.

@jquick-axway jquick-axway added android ios and removed WIP Work in progress labels Aug 25, 2021
@jquick-axway jquick-axway merged commit 5e62dbd into tidev:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants