Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Ti.UI.Picker "change" event not returning row titles from "selectedValue" as of 10.0.1 #12833

Merged
merged 2 commits into from May 26, 2021
Merged

fix(android): Ti.UI.Picker "change" event not returning row titles from "selectedValue" as of 10.0.1 #12833

merged 2 commits into from May 26, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28460

Summary:

  • Wrongly returning array of [object Object] strings instead of row titles.
  • Regression as of 10.0.1. This issue was caught before release.

Note:
I caught this issue when testing kitchensink-v2. It has a "Picker" window where you can see this same issue.

Test:

  1. Build and run SpinnerSimpleTest.js attached to TIMOB-28460 on Android.
  2. Scroll through each column in the spinner.
  3. Verify selected row titles are correctly shown in the log.
    @@@ Selected values: <Row1>,<Row2>,<Row3>

@jquick-axway jquick-axway added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 22, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone May 22, 2021
@build build requested a review from a team May 22, 2021 00:48
@build
Copy link
Contributor

build commented May 22, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 957 skipped out of 15336 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
ios.macos.Titanium.Filesystem.File#getDirectoryListing() can access resource directory files (10.15.5)2.237
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12833/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9154:22
processImmediateQueue@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12833/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9217:18
drainQueues@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12833/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9194:52

Generated by 🚫 dangerJS against e34d74f

garymathews
garymathews approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed

@sgtcoolguy sgtcoolguy merged commit 8fea8ef into tidev:master May 26, 2021
@build build mentioned this pull request May 26, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @lokeshchdhry @garymathews @sgtcoolguy