Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): ScrollableView "views" property wrongly empty before window open as of 10.0.1 #12942

Merged
merged 1 commit into from Jul 13, 2021
Merged

fix(android): ScrollableView "views" property wrongly empty before window open as of 10.0.1 #12942

merged 1 commit into from Jul 13, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28504

Summary:

  • Regression as of Titanium 10.0.1. Caught before release.
  • "views" property does not return same array assigned upon creation before window open, but works after window opens.

Test:
Covered by this PR's unit tests.

@jquick-axway jquick-axway added android bug backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Jul 7, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone Jul 7, 2021
@build build requested a review from a team July 7, 2021 02:50
@build
Copy link
Contributor

build commented Jul 7, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 726 skipped out of 10603 total tests.

Tests:

ClassnameNameTimeError
ios.macos.Titanium.Blobimage dimensions should be reported in pixels (10.15.7)0.094
Error: expected 6 to be 11
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12942/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12942/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.blob.test.js:488:33

Generated by 🚫 dangerJS against 4a00aa2

garymathews
garymathews approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit 9b30837 into tidev:master Jul 13, 2021
@build build mentioned this pull request Jul 13, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @lokeshchdhry @garymathews @sgtcoolguy