Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_0_X] fix(android): ScrollableView "views" property wrongly empty before window open as of 10.0.1 #12953

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

build
Copy link
Contributor

@build build commented Jul 13, 2021

Backport of #12942.
See that PR for full details.

@build build added this to the 10.0.1 milestone Jul 13, 2021
@build build requested a review from a team July 13, 2021 12:54
@build
Copy link
Contributor Author

build commented Jul 13, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 680 skipped out of 11853 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via Promise return value (5.0.2)5.006
Error: done() invoked with non-Error: {"source":{"accuracy":1,"locationServicesEnabled":true,"hasCompass":true,"lastGeolocation":"{\"latitude\":37.4219983,\"longitude\":-122.084,\"altitude\":5,\"accuracy\":20,\"heading\":0,\"speed\":0,\"timestamp\":1626706639000}","apiName":"Ti.Geolocation","bubbleParent":true,"__propertiesDefined__":true},"code":-1,"success":false}
at /ti.geolocation.test.js:610:10
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (5.0.2)5.028
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
ios.iphone.Titanium.Analytics.properties.optedOut can be assigned a Boolean value (14.4.0)5.32
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/D9A50B42-B7BF-444C-AC69-78D2E69C2E31/mocha.app/ti.main.js:8814:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/D9A50B42-B7BF-444C-AC69-78D2E69C2E31/mocha.app/ti.main.js:8877:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/D9A50B42-B7BF-444C-AC69-78D2E69C2E31/mocha.app/ti.main.js:8854:52

Generated by 🚫 dangerJS against d0d3402

@ewanharris ewanharris merged commit 743475a into tidev:10_0_X Jul 19, 2021
@ewanharris ewanharris deleted the backport-12942-to-10_0_X branch July 19, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants