Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): TabGroup bar is wrongly transparent on iOS 15 #12946

Merged
merged 4 commits into from Aug 24, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jul 9, 2021

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28505
https://jira.appcelerator.org/browse/TIMOB-28523

Summary:

  • On iOS 15, the bottom tab bar in a tab group is completely transparent.
    • Should be translucent by default and show the color of tab window.
    • Prevented "tabsBackgroundColor" property from changing the bar color.
  • Breaking-change on iOS 15 set "appearance" to transparent by default. Also requires us to set "scrollEdgeAppearance".

Tab Bar Translucency Test:

  1. Create a Classic app project from template. (Provides tab bar icons.)
  2. Use TabGroupColorWindowTest.js attached to TIMOB-28505 for the "app.js".
  3. Build and run on iOS 15.
  4. Verify bottom bar shows 3 tab titles/icons and is green as shown in the iOS 14 screenshot in TIMOB-28505.
  5. Tap on tab 2 and verify the "red" window shows through the bottom tab bar.
  6. Tap on tab 3 and verify the "blue" window shows through the bottom tab bar.

Tab Bar Color Test:

  1. Create a Classic app project from template. (Provides tab bar icons.)
  2. Use TabGroupColorSharedTest.js attached to TIMOB-28505 for the "app.js".
  3. Build and run on iOS 15.
  4. Verify bottom tab bar's background is light-green.
  5. Tap on tab 2 and 3 and verify tab bar's background is still light-green.

@jquick-axway jquick-axway added this to the 10.1.0 milestone Jul 9, 2021
@build build requested a review from a team July 9, 2021 21:11
@build
Copy link
Contributor

build commented Jul 9, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 955 skipped out of 16915 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.Filesystem.File.remoteBackup assigning Boolean value doesn't throw (14.4.0)2.063
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/8004FEFB-9C69-45DD-8F64-47B0C61BCF24/data/Containers/Bundle/Application/5DDEF462-87FD-4511-8AFD-D0EACC89E206/mocha.app/ti.main.js:9258:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/8004FEFB-9C69-45DD-8F64-47B0C61BCF24/data/Containers/Bundle/Application/5DDEF462-87FD-4511-8AFD-D0EACC89E206/mocha.app/ti.main.js:9321:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/8004FEFB-9C69-45DD-8F64-47B0C61BCF24/data/Containers/Bundle/Application/5DDEF462-87FD-4511-8AFD-D0EACC89E206/mocha.app/ti.main.js:9298:52

Generated by 🚫 dangerJS against 2c1f140

@jquick-axway
Copy link
Contributor Author

Closing since Apple fixed this issue as of Xcode 13 beta 3.

@jquick-axway
Copy link
Contributor Author

Re-opening this PR since the issue came back when testing it with Xcode 13 beta 5.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Pass. TabGroup bar is now displayed as it was on iOS 14

@ewanharris ewanharris merged commit 15e292e into tidev:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants