Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): TabGroup bar is wrongly transparent on iOS 15 #12946

Merged
merged 4 commits into from
Aug 24, 2021
Merged

fix(ios): TabGroup bar is wrongly transparent on iOS 15 #12946

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08a18b8
fix(ios): tab group bar not translucent on iOS 15
jquick-axway Jul 9, 2021
18897af
Merge branch 'master' into TIMOB-28505
jquick-axway Aug 19, 2021
06cb0a4
chore(ios): add iOS 15 guards for TIMOB-28505
jquick-axway Aug 20, 2021
2c1f140
Merge branch 'master' into TIMOB-28505
ewanharris Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions iphone/Classes/TiUITabGroup.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ - (UITabBarController *)tabController
controller.delegate = self;
controller.moreNavigationController.delegate = self;
[TiUtils configureController:controller withObject:self.proxy];
if ([TiUtils isIOSVersionOrGreater:@"15.0"]) {
jquick-axway marked this conversation as resolved.
Show resolved Hide resolved
UITabBarAppearance *appearance = controller.tabBar.standardAppearance;
[appearance configureWithDefaultBackground];
appearance.backgroundColor = UIColor.clearColor;
controller.tabBar.scrollEdgeAppearance = appearance;
}
}
return controller;
}
Expand Down Expand Up @@ -365,6 +371,10 @@ - (void)setTabsBackgroundColor_:(id)value
UITabBar *tabBar = [controller tabBar];
//A nil tintColor is fine, too.
[tabBar setBarTintColor:[color color]];
if ([TiUtils isIOSVersionOrGreater:@"15.0"]) {
jquick-axway marked this conversation as resolved.
Show resolved Hide resolved
tabBar.standardAppearance.backgroundColor = [color color];
tabBar.scrollEdgeAppearance.backgroundColor = [color color];
}
}

- (void)setTabsTintColor_:(id)value
Expand Down