New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): be able to build Titanium project from Xcode again #13032
base: master
Are you sure you want to change the base?
Conversation
Tests:
|
Will this be available soon? |
I haven't had the chance to finish the PR, yet and have to fix the remaining production build issue |
Awesome -- thanks for all your efforts! |
Hi everyone! This one is now ready for review! |
@cb1kenobi Done, thank you! I noticed that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR'd, looks good! Thanks!
Can this be merged? Or are there any obstructions? |
There is still one open issue which I couldn't solve so far (see the open To-do in the first post) |
Ready for review! @janvennemann and/or @cb1kenobi, can you take a look? I disabled the project generation for prod builds for now, so it doesn't interfere with sensitive production CLI settings. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26807
Open issues:
It seems like there is some kind of static file reference leftover in the
_build.js
that causes this. Can someone help here?✅ Building the source from Xcode works again (without wild copying and re-referencing files / build settings)
✅ Incremental builds still work
✅ This also fixes the annoying ARM64 error where one had to manually add "arm64" to the "Excluded Architectures" build setting. The reason was that it was added to the
xcodebuild
command instead of the build setting, so it could not be properly reused from Xcode.