[TIMOB-8446] Window open, close, focus, and blur events not firing when opened with tab.open() #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as well as fixing parity issues compared to ios.
…mob-8446 Conflicts: mobileweb/titanium/Ti/UI.js
… moving the window stack into the Tab element.
…hope we don't have to backport this commit. Merge branch 'master' of github.com:cb1kenobi/titanium_mobile into timob-8446 Conflicts: mobileweb/titanium/Ti/UI.js mobileweb/titanium/Ti/UI/MobileWeb/NavigationGroup.js mobileweb/titanium/Ti/UI/TabGroup.js
| // to set a widget id and css class on the dom node. | ||
| declaredClass: "Ti.UI.TabBarContainer", | ||
|
|
||
| _doLayout: function(params) { |
There was a problem hiding this comment.
The _doLayout method is not used anymore...this code is never called. FWIW I reworked tabgroup in 8275 so that this type of "prelayout" tweaking is not necessary. This method should just be removed.
|
Code reviewed and tested. Request accepted. |
nebrius
added a commit
that referenced
this pull request
May 18, 2012
[TIMOB-8446] Window open, close, focus, and blur events not firing when opened with tab.open()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes splash screen parity.