-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-8446] Window open, close, focus, and blur events not firing when opened with tab.open() #2220
Conversation
…s as well as fixing parity issues compared to ios.
…mob-8446 Conflicts: mobileweb/titanium/Ti/UI.js
… moving the window stack into the Tab element.
…hope we don't have to backport this commit. Merge branch 'master' of github.com:cb1kenobi/titanium_mobile into timob-8446 Conflicts: mobileweb/titanium/Ti/UI.js mobileweb/titanium/Ti/UI/MobileWeb/NavigationGroup.js mobileweb/titanium/Ti/UI/TabGroup.js
// to set a widget id and css class on the dom node. | ||
declaredClass: "Ti.UI.TabBarContainer", | ||
|
||
_doLayout: function(params) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _doLayout method is not used anymore...this code is never called. FWIW I reworked tabgroup in 8275 so that this type of "prelayout" tweaking is not necessary. This method should just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Code reviewed and tested. Request accepted. |
[TIMOB-8446] Window open, close, focus, and blur events not firing when opened with tab.open()
This also fixes splash screen parity.