Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIDOC-353 APIDOC UI.Clipboard rewrite #2269

Merged
merged 8 commits into from May 31, 2012
Merged

TIDOC-353 APIDOC UI.Clipboard rewrite #2269

merged 8 commits into from May 31, 2012

Conversation

hal-gh
Copy link
Contributor

@hal-gh hal-gh commented May 24, 2012

summary: Return true if there is any content in the text portion of the clipboard.
summary: Indicates whether any text data is stored in the clipboard.
description: |
On Android, returns Boolean.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile Web also returns a Boolean.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next update.

@hieupham007
Copy link
Contributor

Docs reviewed. Looks good. There's a pending PR for 9263: #2280 though

@hal-gh
Copy link
Contributor Author

hal-gh commented May 25, 2012

Updated. Please review.

@cb1kenobi
Copy link
Contributor

Docs reviewed for Mobile Web. Accepted.

methods:
- name: clearData
summary: Clear data of the given mime-type from the clipboard. If no mime-type is given, clear all data from the clipboard.
summary: |
Deletes data of the specified MIME type stored in the clipboard. If omitted, all data is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it would beneficial if it said If MIME type omitted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that makes it clearer. Thank you.
Fixed in next update.

@srahim
Copy link
Contributor

srahim commented May 29, 2012

looks pretty much fine , apart for a minor nit pick .

@hieupham007
Copy link
Contributor

Docs re-reviewed. Looks good. Request accepted

@hal-gh
Copy link
Contributor Author

hal-gh commented May 30, 2012

@srahim
Copy link
Contributor

srahim commented May 31, 2012

docs reviewed and ACCEPTED

@srahim
Copy link
Contributor

srahim commented May 31, 2012

Ran validate.py and docgen.py.
Request Approved_

srahim added a commit that referenced this pull request May 31, 2012
TIDOC-353 APIDOC UI.Clipboard rewrite
@srahim srahim merged commit 79b787f into tidev:master May 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants