timob-9263: Clipboard setText should work properly #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this against my new drillbit tests, it appears that clearData is not working properly. According to the docs the argument should be optional, but it appears to be required on Android. Let me know if you want me to open a new bug for this, but it should be an easy fix to make the param optional. |
|
My PR is at: |
|
Updated the current PR with that optional argument fix. |
|
Code reviewed and functionally tested. Also tested clearData() and verified that it works as well. Request Accepted |
|
Also ran drillbit test suite ui.clipboard, and that passed as well. |
ayeung
pushed a commit
that referenced
this pull request
May 30, 2012
timob-9263: Clipboard setText should work properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA: https://jira.appcelerator.org/browse/TIMOB-9263