[TIMOB-9222][TIMOB-9223] Clipboard fixes in honor of Hal. #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2012 14:56
Fix hasText, hasData return values.
Note that these fail on Android because of Bug tidev#9263, fixed in PR#2280: tidev#2280 With that fix, 2 tests still fail on Android because clearData's property should be optional, but isn't.
|
Code reviewed. APPROVED |
mstepanov
pushed a commit
that referenced
this pull request
May 29, 2012
[TIMOB-9222][TIMOB-9223] Clipboard fixes in honor of Hal.
|
I just spotted this - thanks for the tribute, Arthur! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In honor of @PaulDowsett's last week with us, I'm fixing a couple of the bugs he filed on Clipboard. Note that this is a code PR, not docs.
Fixed crashes on setData, hasData. TIMOB-9222
Also fixed hasText, hasData return values. TIMOB-9223
Also added drillbit tests for Clipboard. Note that these fail on Android because of Bug #9263, fixed in PR#2280:
#2280
With that fix, 2 tests still fail on Android because clearData's argument should be optional, but isn't.
I could change the tests to accomodate this bug, but it would be preferable to simply fix clearData while we're doing a PR on Clipboard.