Timob 9493 Android animation regression when animation contains multiple simultaneous transformations. #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aleAnimation, now that I understand it really is needed :)
Conflicts: android/titanium/src/java/org/appcelerator/titanium/util/TiAnimationBuilder.java
|
CR/FR in progress |
|
FT in progress.... |
|
Functional Test PERFECTLY PASSED on Galaxy Tab (3.0), HTC (2.3.4), Emulator (2.3) |
| @@ -414,6 +415,7 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP | |||
| } | |||
| layoutNativeView(); | |||
| } else if (key.equals(TiC.PROPERTY_WIDTH)) { | |||
| resetPostAnimationValues(); | |||
There was a problem hiding this comment.
We should probably call resetPostAnimationValues() on Top/Bottom/Left/Right/Center as well since they all trigger a layout pass.
|
code reviewed. left one comment. |
…rties which, when changed, should cause previous animation values to be forgotten (since a layout pass will occur).
|
Code reviewed. Request Accepted |
|
Ran drillbit as well, and that passed. |
|
FT PASSED on Galaxy Tab (3.0), Emulator (2.3) |
mstepanov
pushed a commit
that referenced
this pull request
Jun 18, 2012
Timob 9493 Android animation regression when animation contains multiple simultaneous transformations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test app and testing notes in JIRA item.