-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 9493 Android animation regression when animation contains multiple simultaneous transformations. #2416
Conversation
…aleAnimation, now that I understand it really is needed :)
Conflicts: android/titanium/src/java/org/appcelerator/titanium/util/TiAnimationBuilder.java
CR/FR in progress |
FT in progress.... |
Functional Test PERFECTLY PASSED on Galaxy Tab (3.0), HTC (2.3.4), Emulator (2.3) |
@@ -414,6 +415,7 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP | |||
} | |||
layoutNativeView(); | |||
} else if (key.equals(TiC.PROPERTY_WIDTH)) { | |||
resetPostAnimationValues(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably call resetPostAnimationValues() on Top/Bottom/Left/Right/Center as well since they all trigger a layout pass.
code reviewed. left one comment. |
…rties which, when changed, should cause previous animation values to be forgotten (since a layout pass will occur).
Code reviewed. Request Accepted |
Ran drillbit as well, and that passed. |
FT PASSED on Galaxy Tab (3.0), Emulator (2.3) |
Timob 9493 Android animation regression when animation contains multiple simultaneous transformations.
See test app and testing notes in JIRA item.