New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-10361] added touchPassThrough property on iOS which allows touches to go throug... #2696
Conversation
…ough when transparent
Signed CLA is in place. |
CR passed. |
Have been communicating with Android teams on how feasible this is on Android, will have to do same with MW. |
Okay, having talked with the other teams, this sounds highly unfeasible in terms of parity, i.e., making something there is either impossible or could cause significant performance problems. What's the underlying use case? The Jira ticket didn't really show a need. |
That doesnt seem hard to do an android Now their are thousands of use cases:
I actually use the 2 cases. |
Conflicts: android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java
I just commited a working android version. |
I can vouch for the validity of these use cases, and others. I've encountered these in apps I've built for Appcelerator, and having this property would greatly reduce the complexity of my code in some cases and make other cases, formerly impossible, possible. |
Okay, will talk with mobile web and see if this is possible or painful. |
any news on this? |
@@ -1004,7 +1013,14 @@ - (UIView *)hitTest:(CGPoint) point withEvent:(UIEvent *)event | |||
} | |||
*/ | |||
|
|||
return [super hitTest:point withEvent:event]; | |||
UIView *hitView = [super hitTest:point withEvent:event]; | |||
if (touchPassThrough) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick: This could be more elegantly written as
if (touchPassThrough && (hitview == self))
{
return nil;
}
return hitView;
Despite Bryan making an odd face when I asked about this, this does have value. Include documentation and update the code (and update the merge) and I'll rereview. |
I am not the best at writing doc. Hope it will be fine! |
@ashcoding Can you check the android part? I'd look at the iOS part. |
Closing this PR, since the merge conflicts have not been addressed since 2 months. |
...h when transparent
jira ticket