Timob 10207: Kitchensink: ImageViews - Animation gets paused after 4-5 frames and resume occurs leaving 1 frame in between #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into timob-10207
| @@ -540,6 +541,11 @@ public void run() | |||
| Log.d(TAG, "set image: " + b.index, Log.DEBUG_MODE); | |||
| setImage(b.bitmap); | |||
| fireChange(b.index); | |||
|
|
|||
| if (isWakingFromPause) { | |||
There was a problem hiding this comment.
I would name this to something less confusing like 'waitExtraFrameOnResume', and also leave a comment on what you are doing here.
|
It looks like we get the wrong duration value when you do the following:
We probably need to store the duration in a variable so we don't use the most update-to-date one in the proxy if the user did not stop/start the animation again. You may also want to add this behavior in the docs (it says you need to do this in KS but not the docs) |
|
Code reviewed and functionally tested. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Aug 10, 2012
Timob 10207: Kitchensink: ImageViews - Animation gets paused after 4-5 frames and resume occurs leaving 1 frame in between
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-10207
Test case in JIRA.