Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timob 10207: Kitchensink: ImageViews - Animation gets paused after 4-5 frames and resume occurs leaving 1 frame in between #2697

Merged
merged 4 commits into from
Aug 10, 2012
Merged

Timob 10207: Kitchensink: ImageViews - Animation gets paused after 4-5 frames and resume occurs leaving 1 frame in between #2697

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8289f4e
timob-10207: wait for one period to make sure the frame shows when wa…
pingwang2011 Aug 8, 2012
2443ab5
Merge branch 'master' of git://github.com/appcelerator/titanium_mobil…
pingwang2011 Aug 8, 2012
93ad30b
timob-10207: add comment
pingwang2011 Aug 10, 2012
266f443
timob-10207: store the duration in a variable and update doc
pingwang2011 Aug 10, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIImageView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,12 +526,13 @@ public Animator(Loader loader)

public void run()
{
boolean isWakingFromPause = false;
try {

if (paused) {
synchronized (this) {
KrollDict data = new KrollDict();
proxy.fireEvent(TiC.EVENT_PAUSE, data);
isWakingFromPause = true;
wait();
}
}
Expand All @@ -540,6 +541,11 @@ public void run()
Log.d(TAG, "set image: " + b.index, Log.DEBUG_MODE);
setImage(b.bitmap);
fireChange(b.index);

if (isWakingFromPause) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name this to something less confusing like 'waitExtraFrameOnResume', and also leave a comment on what you are doing here.

Thread.sleep((int) getDuration());
isWakingFromPause = false;
}
} catch (InterruptedException e) {
Log.e(TAG, "Loader interrupted");
}
Expand Down