Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersistentHTTPClient #2844

Closed
wants to merge 5 commits into from
Closed

PersistentHTTPClient #2844

wants to merge 5 commits into from

Conversation

farfromrefug
Copy link
Contributor

Continuing that pull request, here is a new implementation for it.
As i explained in the other pull request, i cant do that in a module as i cant subclass anything but view and proxy.

Also i cant provide an address for testing as the one is authenticated. I am really sorry about that. I have been looking for a test one but couldnt find anything yet.
I am heavily using the ios implementation.

@negupta
Copy link
Contributor

negupta commented Aug 29, 2012

Signed CLA is in place.

@ghost ghost assigned WhichKatieDid Oct 1, 2012
@farfromrefug
Copy link
Contributor Author

Any news on this?
I have been using it without any problem

@WhichKatieDid
Copy link
Contributor

Looks good codewise. It does need documentation and an updated merge.

 into new_comet

Conflicts:
	iphone/iphone/Titanium.xcodeproj/project.pbxproj
@farfromrefug
Copy link
Contributor Author

wow it s an old one :s
So i merged it
Now about the doc. I created the doc file but i am not sure how to feel it as it is just a subclass of HttpClient. Any help on this?

@ingo
Copy link
Contributor

ingo commented Feb 21, 2014

Thank you for the submission. We are going to be replacing ASIHttp with NSUrlConnection (as seen in TIMOB-15980) which we believes solves the functionality noted here. Please take a look and let us know your thoughts. Closing this PR for now.

@farfromrefug
Copy link
Contributor Author

great news, will have to recheck it all ;)
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants