[TC-1372] selectedColor for android button #3165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIButton.java
|
Thank you very much for your PR. This is considered a non-native behavior and we prefer not to support it. Those interested in the functionality can merge the PR in a custom SDK. |
|
Well that implementation was not native i ll give you that :D But i completely understand, was far too old anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira ticket
I should mention that i had to use a trick because the button highlighted state is note set directly on touch down. So i had to use a timer and try and find the exact time :s Couldn t find anything on the web about that timing difference.
There also a little delay on touch up (about 60ms i think) but as it is not spottable, i did not delay anything.