New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Ti.UI.ListView - scroll, scrollend, dragend, dragstart events #4086
Conversation
scroll, scrollend, dragstart, dragend events added to Ti.UI.ListView
implementation of headerPullView copied from TiUITableView
I also added headerPullView implementation |
I could not find a signed CLA in place. Did you sign one? |
I don't know what is CLA and why it must be signed :) sorry. |
Hi @darknos, You can go here and sign to CLA: http://developer.appcelerator.com/cla More informations here: https://wiki.appcelerator.org/display/guides/How+to+Contribute+Code#HowtoContributeCode-SigningtheContributorsLicenseAgreement(CLA) |
Oh... I don't have enough time for it... sorry. I created module with these events and just wanted to help Titanium guys. :) |
Closing the pull request as the submitter has declined to sign CLA. |
Reopening the pull request as signed CLA is available now. |
Hi i want to add scroll, scrollend event listeners for android listview. Anyone can help me? |
Hi, I can send you titanium-ui.jar with module compiled with scroll and scrolled events. just replace it with existing in 3.1.0.GA to get these events. or you can download and compile 3.1.1 from my fork https://github.com/darknos/titanium_mobile/tree/3_1_X Sergey Nosenko On Wednesday, 22 May 2013 р. at 15:16, maroofsaeed wrote:
|
Please send me the jar file......... |
titanium-ui.jar (http://db.tt/671nVZTZ) Sergey Nosenko On Wednesday, 22 May 2013 р. at 16:04, maroofsaeed wrote:
|
Bundle of thanks sir. |
Sir another question, all working well regarding scroll event but if i gave the callback function like this: listView.addEventListener('scroll', loadmore); and in loadmore function when i am getting the values like e.totalItemCount...... its not working as saying e is undefined. But if i add like this listView.addEventListener('scroll', function(e){ e is working all ok. what is wrong with this? |
@maroofsaeed What is loadmore defined as? Also, what is the state of this pull? The submitter needs to re-merge with the main branch, for one. |
@darknos Thank you for the Pull Request. Sorry we can not accept this PR as tableheaderview has already been implemented as pullview and we have decided not to expose the other events as its is no longer needed/ is not in the intended spec. |
hmm... so can you describe how to implement lazy loading without scroll event? how to implement pull to request using table header view which is allways on the screen |
@srahim, I'm also interested in how lazy loading/infinite scrolling will be implemented without scroll event. Can you tell us what the current plan is? |
@darknos if I want to include your changes for ListView - particularly for the Scroll events for iOS, what should be the procedure? Should I just copy your version of the files to /Library/Application Support/Titanium/mobilesdk/osx/3.1.2.GA/iphone/Classes ? |
I am new to Titanium development so excuse my ignorance here, but how can I get ListView scrolling events if I am using 3.1.2 GA? @darknos if you could explain it to me like I was stupid, I would appreciate it. :) Looking through the comments makes me think that the scrolling issue has been fixed by @darknos but you guys are ignoring it for no reason? I need scroll events on ListView because it works better on android then the tableview, and I need to implement lazy-loading. What's the hold up? |
@chadstachowicz @contractorwolf @archiepanda @alejandrothorne @darknos Pull Refresh has implemented in ticket TIMOB-13418 . For lazy loading we implemented a new event "marker" , where the developer can set markers at a particular point in the listview and as soon the OS starts to render view regarding the particular cell the marker event would be fired. Both Features are available only on the master branch(3.2.0) right now. You can grab any recent build from the C.I page to test out this feature. Hopefully this helps in alleviating any concerns and confusion. I apologize for the delay in response, as we do not usually monitor closed out PR's for comment. In future, for a quicker response do create a Q&A thread. |
@srahim thanks for this response. My main concern is that all of the tickets referenced are for iOS, and the feature set we are concerned about is for Android. Can you please point us to the related feature sets on android? Thanks! Chad |
@srahim This seems to be the ticket for the markers also fixed in 3.2.0 https://jira.appcelerator.org/browse/TIMOB-14320 but I can't find anything to help on pull to refresh. Chad |
@chadstachowicz this PR was made against iOS. Pull to Refresh was never planned to be implemented in Android. Its a iOS only feature. |
Am using 3.1.3.GA sdk and whether marker is not supported and saying as undefined method?. Will that work else have to use TableView for lazy loading?? |
https://github.com/darknos/TiAdvancedListView This is a module based on 3.2.0 code with marker and pulldown support for guys who can’t wait for 3.2.0 in app.js var TiAdvancedListView = require("ti.advanced.list.view”); //one new feature. use following to prevent remote image loading on scroll Sergey Nosenko On Wednesday, 6 November 2013 р. at 11:20, jAddict7 wrote:
|
darknos... thanks so much! |
I don't know why these events were ignored in the first version of ListView (great job!), so I decided to contribute my small efforts to this great component.
I think it is quite simple to do this for Android too.