Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-14319] marker event. #4528

Merged
merged 7 commits into from
Aug 1, 2013
Merged

[TIMOB-14319] marker event. #4528

merged 7 commits into from
Aug 1, 2013

Conversation

vishalduggal
Copy link
Contributor

Test is in JIRA

@ghost ghost assigned srahim Aug 1, 2013
@srahim
Copy link
Contributor

srahim commented Aug 1, 2013

Code Reviewed and APPROVED

- name: marker
summary: Fired when the list view displays the reference item or an item beyond the reference item.
description: |
This event is fired `only once`. Use this in conjunction with the [setMarker](Titanium.UI.ListView.setMarker) method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks indiciate code/monotype. I would use double asterisks for bolding.

name: ListViewMarkerProps
summary: The parameter for [setMarker](Titanium.UI.ListView.setMarker) method.
description: |
Use this in conjunction with the [setMarker](Titanium.UI.ListView.setMarker) method. For example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a colon to the end of 'For example'

@bhatfield
Copy link
Contributor

Reviewed. Ran validate and deploy. Left a few comments.

@srahim
Copy link
Contributor

srahim commented Aug 1, 2013

Functionally Tested and APPROVED

Doc reviewed and APPROVED

srahim added a commit that referenced this pull request Aug 1, 2013
@srahim srahim merged commit 023844d into tidev:master Aug 1, 2013
@vishalduggal vishalduggal deleted the timob-14319 branch October 27, 2014 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants