[TIMOB-10688] #4210
Merged
[TIMOB-10688] #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring output This will be used mainly for module doc generation. Allows us to validate against the Titanium docs, but only output the module's docs
…and option to skip it
| @@ -163,8 +164,14 @@ def generate_output(options): | |||
| generator.generate(apis, annotated_apis, options) | |||
|
|
|||
| def process_yaml(source_dirs): | |||
| global apis | |||
| global apis, options | |||
There was a problem hiding this comment.
Rather than make options a global, we should follow the usage elsewhere and pass it as a parameter. (See generate_output immediately above).
… argument, options
|
Fixed process_yaml to accept a 2nd optional arg named options as suggested. |
|
FR passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing notes in TIMOB-10688.