TIMOB-12970 Android: Support and document the availableCameras property in Ti.Media. #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
|
||
| <uses-sdk android:minSdkVersion="8" /> | ||
| <uses-sdk android:minSdkVersion="9" /> |
There was a problem hiding this comment.
Why it's "9" here instead of "10"?
|
Ran the test case on HTC sensation 4G (2.3.6), Galaxy Nexus (4.0.4), Galaxy Tab (3.2), Nexus 7 (4.1) and all passed. FR passed . Left a few minor comments. |
Conflicts: android/runtime/v8/AndroidManifest.xml
The "since" key for ipad/iphone in Media.yml availableCameras, CAMERA_FRONT and CAMERA_REAR entries were not needed because they've been there for some time though undocumented. TIMOB-12970
|
@pingwang2011 Thank you, I made the doc changes (getting rid of "since" entries for ipad/iphone) and merged master. The merge from master actually set that api level to 10 appropriately. |
| type: Array<Number> | ||
| platforms: [iphone, ipad, android] | ||
| since: | ||
| iphone: "3.2.0" |
There was a problem hiding this comment.
Need to remove iphone and ipad here too.
availableCameras TIMOB-12970
|
@pingwang2011 Okay, that's in there too now. |
|
Code and doc reviewed. Ran docgen.py. All passed. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Aug 6, 2013
TIMOB-12970 Android: Support and document the availableCameras property in Ti.Media.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA for testing notes.
There is a doc change in here, so don't forget to test that too.