-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-12970 Android: Support and document the availableCameras property in Ti.Media. #4450
Conversation
|
||
<uses-sdk android:minSdkVersion="8" /> | ||
<uses-sdk android:minSdkVersion="9" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's "9" here instead of "10"?
Ran the test case on HTC sensation 4G (2.3.6), Galaxy Nexus (4.0.4), Galaxy Tab (3.2), Nexus 7 (4.1) and all passed. FR passed . Left a few minor comments. |
Conflicts: android/runtime/v8/AndroidManifest.xml
The "since" key for ipad/iphone in Media.yml availableCameras, CAMERA_FRONT and CAMERA_REAR entries were not needed because they've been there for some time though undocumented. TIMOB-12970
@pingwang2011 Thank you, I made the doc changes (getting rid of "since" entries for ipad/iphone) and merged master. The merge from master actually set that api level to 10 appropriately. |
type: Array<Number> | ||
platforms: [iphone, ipad, android] | ||
since: | ||
iphone: "3.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove iphone and ipad here too.
availableCameras TIMOB-12970
@pingwang2011 Okay, that's in there too now. |
Code and doc reviewed. Ran docgen.py. All passed. Accepted |
TIMOB-12970 Android: Support and document the availableCameras property in Ti.Media.
See JIRA for testing notes.
There is a doc change in here, so don't forget to test that too.