Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMOB-12148 set DisplayShowTitleEnabled #4480

Merged
merged 2 commits into from Dec 2, 2013
Merged

IMOB-12148 set DisplayShowTitleEnabled #4480

merged 2 commits into from Dec 2, 2013

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Jul 24, 2013

hieupham007
hieupham007 reviewed Jul 29, 2013
View reviewed changes
android/titanium/src/java/org/appcelerator/titanium/proxy/ActionBarProxy.java
@@ -160,7 +160,6 @@ private void handleSetIcon(String url)
private void handleSetTitle(String title)
{
if (actionBar != null) {
actionBar.setDisplayShowTitleEnabled(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you deleting this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting this . worked fine for me. I tested this scenario also

@hieupham007
Copy link
Contributor

It seems that this is an ICS issue: https://code.google.com/p/styled-action-bar/issues/detail?id=3
with workarounds similar to what you have: http://stackoverflow.com/questions/11002691/actionbar-setbackgrounddrawable-nulling-background-from-thread-handler

Can you verifiy if this is happening only on ICS (4.0+), or does it happening with 2.3.x and 4.2.x as well?

hieupham007
hieupham007 reviewed Jul 29, 2013
View reviewed changes
android/titanium/src/java/org/appcelerator/titanium/proxy/ActionBarProxy.java
@@ -194,6 +193,8 @@ private void handleSetBackgroundImage(String url)

Drawable backgroundImage = getDrawableFromUrl(url);
if (backgroundImage != null) {
actionBar.setDisplayShowTitleEnabled(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably leave a comment for this workaround (with link to the original android bug). I.e: This is a workaround due to https://code.google.com/p/styled-action-bar/issues/detail?id=3. [TIMOB-12148]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hieupham007
Copy link
Contributor

Any update on this?

@bijupmb
Copy link
Contributor Author

bijupmb commented Sep 19, 2013

actionBar.setDisplayShowTitleEnabled(false);
actionBar.setDisplayShowTitleEnabled(true);

Is this ok for this bug ?

@hieupham007
Copy link
Contributor

Yes, that fix is ok for this issue, but please add a comment above actionBar.setDisplayShowTitleEnabled(false);
saying "This is a workaround due to https://code.google.com/p/styled-action-bar/issues/detail?id=3. [TIMOB-12148]"

@hieupham007
Copy link
Contributor

Any update for this issue?

@bijupmb
Copy link
Contributor Author

bijupmb commented Oct 31, 2013

I will check and update soon

@ghost ghost assigned hieupham007 Nov 19, 2013
@hieupham007
Copy link
Contributor

Looks good, merging.

hieupham007 added a commit that referenced this pull request Dec 2, 2013
@hieupham007
Merge pull request #4480 from bijupmb/TIMOB-12148-ActionBarBgImagenot…
9d15a80 
…setPropertyInClick

IMOB-12148 set DisplayShowTitleEnabled
@hieupham007 hieupham007 merged commit 9d15a80 into tidev:master Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hieupham007 hieupham007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bijupmb @hieupham007