Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMOB-12148 set DisplayShowTitleEnabled #4480

Merged
merged 2 commits into from
Dec 2, 2013
Merged

IMOB-12148 set DisplayShowTitleEnabled #4480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844dfa0
IMOB-12148 set DisplayShowTitleEnabled
Jul 24, 2013
765ea65
TIMOB-12148 modified add comment
bijupmb Nov 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/titanium/src/java/org/appcelerator/titanium/proxy/ActionBarProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ private void handleSetIcon(String url)
private void handleSetTitle(String title)
{
if (actionBar != null) {
actionBar.setDisplayShowTitleEnabled(true);
actionBar.setTitle(title);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you deleting this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting this . worked fine for me. I tested this scenario also

} else {
Log.w(TAG, "ActionBar is not enabled");
Expand Down Expand Up @@ -193,7 +192,10 @@ private void handleSetBackgroundImage(String url)
}

Drawable backgroundImage = getDrawableFromUrl(url);
//This is a workaround due to https://code.google.com/p/styled-action-bar/issues/detail?id=3. [TIMOB-12148]
if (backgroundImage != null) {
actionBar.setDisplayShowTitleEnabled(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably leave a comment for this workaround (with link to the original android bug). I.e: This is a workaround due to https://code.google.com/p/styled-action-bar/issues/detail?id=3. [TIMOB-12148]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

actionBar.setDisplayShowTitleEnabled(true);
actionBar.setBackgroundDrawable(backgroundImage);
}
}
Expand Down