Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-14371] Anvil tests #4499

Conversation

shameer49
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-14371
//fixes of includes/includes and commonjs/commonjs suites

var b = require('commonjs/relative/submodule/b');
// Actual path from root directory("Resources") to relative/submodule -> Resources/suites/commonjs/relative/submodule
var a = require('/suites/commonjs/relative/submodule/a');//Path modified to correct absolute path
var b = require('/suites/commonjs/relative/submodule/b');//Path modified to correct absolute path

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just defeats the purpose of the test case. This test is to see if relative paths work.

the goal of anvil test is not to get every testing passing. Rather it is to check if any broke in the SDK.

@srahim
Copy link
Contributor

srahim commented Sep 27, 2013

Address review comments.

@shameer49
Copy link
Contributor Author

Duplicated by #4540 .Closing PR

@shameer49 shameer49 closed this Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants