[TIMOB-14371] Anvil tests #4540
Conversation
|
Why do you have two PR's with simillar commits ? Contains same code from #4499 |
|
Sorry for the inconvenience. Actually our machine had been crashed and we were unable to add new changes to the submitted branch. so we submitted two PR's for the same ticket. |
ghost
assigned 
| var b = require('commonjs/relative/submodule/b'); | ||
| // Actual path from root directory("Resources") to relative/submodule -> Resources/suites/commonjs/relative/submodule | ||
| var a = require('/suites/commonjs/relative/submodule/a');//Path modified to correct absolute path | ||
| var b = require('/suites/commonjs/relative/submodule/b');//Path modified to correct absolute path |
There was a problem hiding this comment.
this wrong the test is to check for relative pathing not absolute. Breaks functionality.
|
On iOS, for commonjs suite all test fail except "test_name_utils". On android all tests pass. Changes to includejs, network_httpclient & yahoo suites looks good on both platforms. |
|
In IOS there exist an issue that the IOS anvil does not work with any relative path but when we replace that to absolute path it works fine.That is why commonjs test fail in IOS. |
|
The fix for include.js is not proper because its working fine on Titanium studio. We are still confused with this behavior of include function. |
|
As per the doc. On iOS, all relative paths are currently interpreted as relative to the Resources directory, not to the current context. |
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| exports.run = function(testRun, valueOf) { | |||
| valueOf(testRun, function() { | |||
| require('./submodule/a'); | |||
| require('submodule/a');//Modified to invalid path to create exception | |||
There was a problem hiding this comment.
this should actually fail as there is a submodule/a exist. SInce our relative path does not work quite right this would pass. Just change it to something that doesnot exist like foo/bar
|
@shameer49 @srahim Is this still valid or can I close? |
|
We're just going to fix this against the Mocha versions. |
https://jira.appcelerator.org/browse/TIMOB-14371
fixes to TIMOB-14371
test: includes/includes
commonjs/commonjs
yahoo
network_httpclient