timob-14349: Implementing setCacheMode for web view #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
No test steps in JIRA. |
| if (Build.VERSION.SDK_INT >= 9) { | ||
| nativeView.setOverScrollMode(TiConvert.toInt(newValue, View.OVER_SCROLL_ALWAYS)); | ||
| } | ||
| } else if (TiC.PROPERTY_CACHE_MODE.equals(key)) { |
There was a problem hiding this comment.
I think you need to add TiC.PROPERTY_CACHE_MODE to propertyAccessors in WebViewProxy.java. Otherwise, propertyChanged() may not work.
|
The PR is not merge-able now. Please merge with master. |
…e into timob-14349 Conflicts: android/modules/ui/src/java/ti/modules/titanium/ui/WebViewProxy.java android/modules/ui/src/java/ti/modules/titanium/ui/widget/webview/TiUIWebView.java apidoc/Titanium/UI/WebView.yml
|
Merged. |
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Aug 19, 2013
timob-14349: Implementing setCacheMode for web view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing steps in JIRA