-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timob-14349: Implementing setCacheMode for web view #4510
Conversation
No test steps in JIRA. |
if (Build.VERSION.SDK_INT >= 9) { | ||
nativeView.setOverScrollMode(TiConvert.toInt(newValue, View.OVER_SCROLL_ALWAYS)); | ||
} | ||
} else if (TiC.PROPERTY_CACHE_MODE.equals(key)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add TiC.PROPERTY_CACHE_MODE to propertyAccessors in WebViewProxy.java. Otherwise, propertyChanged() may not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind.
The PR is not merge-able now. Please merge with master. |
…e into timob-14349 Conflicts: android/modules/ui/src/java/ti/modules/titanium/ui/WebViewProxy.java android/modules/ui/src/java/ti/modules/titanium/ui/widget/webview/TiUIWebView.java apidoc/Titanium/UI/WebView.yml
Merged. |
Code reviewed and functionally tested. Accepted |
timob-14349: Implementing setCacheMode for web view
testing steps in JIRA