Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-5823] Build directly to iOS device #4898

Merged
merged 27 commits into from Nov 2, 2013
Merged

[TIMOB-5823] Build directly to iOS device #4898

merged 27 commits into from Nov 2, 2013

Conversation

cb1kenobi
Copy link
Contributor

This PR also fixes:

TIMOB-15562 CLI: xcode command line tools - Ti CLI cannot recognize xcode command line tools
TIMOB-15569 OS X 10.9: No output from warn, info, debug when debugging
TIMOB-13348 iOS: Build for device: Build fails with CompileC ApplicationRouting
TIMOB-13663 CLI: iOS "build only" option in conjunction with target "device" or "dist-adhoc" does not produce an ipa
TIMOB-13312 CLI: Improve prompting for certificate choice during distribution build
TIMOB-14138 CLI: iOS: Immediately call the pre-compile phase after the prepare phase
TIMOB-13984 CLI: iOS: Sometimes the generated ApplicationRouting.m file is incomplete
TIMOB-15604 CLI: iOS fails to build to simulator
TIMOB-15615 Android: Project built with google API key fails with error "API key not found"
TIMOB-14629 CLI: iOS Symbols wrongly imported from metadata.json
TIMOB-15245 CLI: Killing running app launched in iOS simulator presents unexpected console output including "project failed to build"
It also partially solves:

[TIMOB-15587] Android: Implement secure storage for tiapp.xml properties
[TIMOB-15623] iOS: Secure tiapp.xml properties

…63] Fixed --build-only for device and dist builds. [TIMOB-14138] Changed logic to call pre-compile phase after prepare phase instead of during the Xcode build phase. Also updated the ios build to use the Builder object.
… support for <meta-data> tags as child nodes to <application> tags in the AndoridManifest lib. [TIMOB-15562] Removed OS X CLI tools detection from iOS detection lib. Android build bug fixes and tweaks. Android 9 patch splash screens now go in res-nodpi.
Conflicts:
	iphone/cli/commands/_build.js
…g tiapp.xml properties for both Android and iOS.
@srahim
Copy link
Contributor

srahim commented Nov 1, 2013

Code Reviewed and APPROVED for iOS.

@helloszabi
Copy link

man, you're the best!
thanks for the fixes

@srahim
Copy link
Contributor

srahim commented Nov 1, 2013

Failed for-TIMOB-13663

LOG OUTPUT

ti build -p ios -T dist-adhoc -F iphone
Titanium Command-Line Interface, CLI version 3.2.0, Titanium SDK version 3.2.0.20131102033145
Copyright (c) 2012-2013, Appcelerator, Inc. All Rights Reserved.

Please report bugs to http://jira.appcelerator.org/

/usr/local/lib/node_modules/titanium/node_modules/longjohn/dist/longjohn.js:184
throw e;
^
ReferenceError: maxDevCertLen is not defined
at fields.select.formatters.option (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/iphone/cli/commands/_build.js:452:59)
at Select. (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/fields/lib/types/select.js:102:39)
at Array.forEach (native)
at Select._prerender (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/fields/lib/types/select.js:98:11)
at Select. (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/fields/lib/types/select.js:118:30)
at Array.forEach (native)
at Select._prerender (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/fields/lib/types/select.js:116:24)
at Select.prompt (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/fields/lib/types/select.js:209:34)
at /usr/local/lib/node_modules/titanium/lib/cli.js:939:12

at callback.options.distribution-name.prompt (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/iphone/cli/commands/_build.js:444:9)

at /usr/local/lib/node_modules/titanium/node_modules/async/lib/async.js:693:21
at Array.forEach (native)
at _each (/usr/local/lib/node_modules/titanium/node_modules/async/lib/async.js:32:24)
at _insert (/usr/local/lib/node_modules/titanium/node_modules/async/lib/async.js:678:11)
at q.push (/usr/local/lib/node_modules/titanium/node_modules/async/lib/async.js:705:15)
at /usr/local/lib/node_modules/titanium/lib/cli.js:1018:9
at Array.forEach (native)
at CLI.prompt (/usr/local/lib/node_modules/titanium/lib/cli.js:1017:43)

at run (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/node-appc/lib/subprocess.js:57:8)
at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/iphone/cli/lib/detect.js:369:9
at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/async/lib/async.js:508:21
at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/async/lib/async.js:224:13
at /Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/async/lib/async.js:108:13
at Array.forEach (native)
at _each (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/async/lib/async.js:32:24)
at async.each (/Users/sabilrahim/Library/Application Support/Titanium/mobilesdk/osx/3.2.0.20131102033145/node_modules/async/lib/async.js:107:9)

@cb1kenobi
Copy link
Contributor Author

@srahim Fixed the "maxDevCertLen is not defined" bug.

@srahim
Copy link
Contributor

srahim commented Nov 1, 2013

Functionally Tested and approved for timob-5823

@ayeung
Copy link
Contributor

ayeung commented Nov 2, 2013

Code reviewed and functionally tested. Request Accepted.

ayeung pushed a commit that referenced this pull request Nov 2, 2013
[TIMOB-5823] Build directly to iOS device
@ayeung ayeung merged commit 40b1bac into tidev:master Nov 2, 2013
@cb1kenobi cb1kenobi deleted the ios-build-refactor branch November 2, 2013 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants