[TIMOB-15623] tiapp.xml secured and encrypted properties #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added these properties to "listProperties" and "hasProperties". A debug log letting the developer know that these properties cannot be removed on "removeProperty" has also been added
|
IMPORTANT |
|
This probably needs to be merged with master to get the changes from #4898 |
| jsonData = [NSData dataWithContentsOfFile:tiAppPropertiesPath]; | ||
| } | ||
| NSError *error = nil; | ||
| props = [[NSJSONSerialization JSONObjectWithData:jsonData options:0 error:&error] retain]; |
There was a problem hiding this comment.
Should check for error value in case anything wrong happens.
There was a problem hiding this comment.
Should also ensure that the return object type isKindOfClass NSDictionary
|
There couple of other issues. |
| NSError *error = nil; | ||
| props = [[NSJSONSerialization JSONObjectWithData:jsonData options:0 error:&error] retain]; | ||
| if(error != nil) { | ||
| DebugLog(@"[WARN] Could not load tiapp.xml properties, error was %@", [error localizedDescription]); |
|
Minor Comments. Starting FR |
|
FR Passed. Merging. |
vishalduggal
added a commit
that referenced
this pull request
Nov 5, 2013
[TIMOB-15623] tiapp.xml secured and encrypted properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.