[TIMOB-16121] Expose navBarHidden for iPad Split Window as per JIRA TIMOB-16121 #5643
Conversation
| @@ -146,6 +146,12 @@ -(BOOL)_handleClose:(id)args | |||
|
|
|||
| -(void)viewWillAppear:(BOOL)animated | |||
| { | |||
| if (controller!=nil) | |||
| { | |||
| id navBarHidden = [self valueForUndefinedKey:@"navBarHidden"]; | |||
There was a problem hiding this comment.
Check if this [self valueForUndefinedKey:@"navBarHidden"] is not nil before going forward. Maybe it could go inside the if(controller != nil) statement.
There was a problem hiding this comment.
Doesn't the TiUtils boolValue on the next line account for the nil, and return the default value (in this case NO) if its not present?
| @@ -146,6 +146,12 @@ -(BOOL)_handleClose:(id)args | |||
|
|
|||
| -(void)viewWillAppear:(BOOL)animated | |||
| { | |||
| if (controller!=nil) | |||
| { | |||
There was a problem hiding this comment.
Curly bracket on the same line as the if
There was a problem hiding this comment.
Ok easy fix, will commit and do again after resolving your other comment.
|
Ok I've updated the file to reflect both your suggestions |
|
Hi, I've fixed the issues. Can you please merge this in now? Thanks, |
ingo
changed the title
|
@pec1985 Ping. Could you merge this? |
|
This is a piecemeal fix for the users specific issue. See PR #6603 which is a general fix for all TiWindowProxy objects. |
|
Thanks for your help. The fix has been added in PR #6603 |
This is for changes suggested by an Appcelerator employee in the following JIRA issue:
https://jira.appcelerator.org/browse/TIMOB-16121
I have previously signed the Appcelerator Titanium contribution agreement.