TIMOB-17539-Dont consume event while processing swipe #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return fireEvent(TiC.EVENT_SWIPE, data); | ||
| // we don't want to consume the event by returning here as the framework may still | ||
| // need the event to process scrolling etc - TIMOB-17539 | ||
| fireEvent(TiC.EVENT_SWIPE, data); |
There was a problem hiding this comment.
This will break apps that rely on this event being consumed.
|
Sunil, this change alters the current Android touch architecture, i.e all gesture events are consumed if there's an active listener. This should not be merged into master, but developers can use this as a workaround if they want swipe to NOT consume the touch event as they see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that we don't consume the fling event by returning true.
https://jira.appcelerator.org/browse/TIMOB-17539