Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-17539-Dont consume event while processing swipe #6114

Closed
wants to merge 1 commit into from
Closed

TIMOB-17539-Dont consume event while processing swipe #6114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,9 @@ public boolean onFling(MotionEvent e1, MotionEvent e2, float velocityX, float ve
} else {
data.put(TiC.EVENT_PROPERTY_DIRECTION, velocityY > 0 ? "down" : "up");
}
return fireEvent(TiC.EVENT_SWIPE, data);
// we don't want to consume the event by returning here as the framework may still
// need the event to process scrolling etc - TIMOB-17539
fireEvent(TiC.EVENT_SWIPE, data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break apps that rely on this event being consumed.

}
return false;
}
Expand Down