[TIMOB-17876][TIMOB-17929] Enable apps with 64 bit slice in titanium #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn on GCC_WARN_64_TO_32_BIT_CONVERSION flag and fix code for the same
Modules targeting the SDK with the new JSCore will need an updated path to the headers
All supported architectures now will depend on the SDK/Xcode combination used to build the application
Resolving merge conflicts here itself so it can be merged back into master easily
| @@ -101,7 +101,7 @@ | |||
| TiValueRef length = TiObjectGetProperty(jsContext, obj, kTiStringLength, NULL); | |||
| double len = TiValueToNumber(jsContext, length, NULL); | |||
| NSMutableArray* resultArray = [[NSMutableArray alloc] initWithCapacity:len]; | |||
| for (size_t c=0; c<len; ++c) | |||
| for (uint c=0; c<len; ++c) | |||
| { | |||
There was a problem hiding this comment.
The variable "c" is uint but "len" is long. I'm ok with this, but you're comparing two variable types here.
|
Code reviewed. Testing now |
This issue only occurs on 64 bit simulators
|
The CoverFlowView does not work. Found a fix, change all the |
|
Ready for review |
Hyper loop CLI hook needs this to be defined
|
FT pass |
jonalter
added a commit
that referenced
this pull request
Nov 18, 2014
[TIMOB-17876][TIMOB-17929] Enable apps with 64 bit slice in titanium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for
TIMOB-17876
TIMOB-17929
This PR also makes additional changes for the following
TIMOB-17927
TIMOB-18027