Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17876][TIMOB-17929] Enable apps with 64 bit slice in titanium #6357

Merged
merged 18 commits into from
Nov 18, 2014
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions iphone/Classes/AFOpenFlow/AFItemView.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@

@interface AFItemView : UIView {
UIImageView *imageView;
int number;
NSUInteger number;
CGFloat horizontalPosition;
CGFloat verticalPosition;
CGFloat originalImageHeight;
}

@property int number;
@property NSUInteger number;
@property (nonatomic, readonly) CGFloat horizontalPosition;
@property (nonatomic, readonly) CGFloat verticalPosition;
@property (nonatomic, readonly) UIImageView *imageView;
Expand Down
4 changes: 2 additions & 2 deletions iphone/Classes/AFOpenFlow/AFItemView.m
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ - (void)setImage:(UIImage *)newImage originalImageHeight:(CGFloat)imageHeight re
self.frame = CGRectMake(0, 0, newImage.size.width, newImage.size.height);
}

- (int)number {
- (NSUInteger)number {
return number;
}

- (void)setNumber:(int)newNumber {
- (void)setNumber:(NSUInteger)newNumber {
horizontalPosition = COVER_SPACING * newNumber;
number = newNumber;
}
Expand Down
20 changes: 10 additions & 10 deletions iphone/Classes/AFOpenFlow/AFOpenFlowView.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
CGFloat defaultImageHeight;

UIScrollView *scrollView;
int lowerVisibleCover;
int upperVisibleCover;
int numberOfImages;
int beginningCover;
NSUInteger lowerVisibleCover;
NSUInteger upperVisibleCover;
NSUInteger numberOfImages;
NSUInteger beginningCover;

AFItemView *selectedCoverView;

Expand All @@ -64,23 +64,23 @@
@property (nonatomic, assign) id <AFOpenFlowViewDataSource> dataSource;
@property (nonatomic, assign) id <AFOpenFlowViewDelegate> viewDelegate;
@property (nonatomic, retain) UIImage *defaultImage;
@property (nonatomic) int numberOfImages;
@property (nonatomic) NSUInteger numberOfImages;

- (void)setSelectedCover:(int)newSelectedCover;
- (void)setSelectedCover:(NSUInteger)newSelectedCover;
- (void)centerOnSelectedCover:(BOOL)animated;
- (void)setImage:(UIImage *)image forIndex:(int)index;
- (void)setImage:(UIImage *)image forIndex:(NSUInteger)index;
- (void)updateLayout;

@end

@protocol AFOpenFlowViewDelegate <NSObject>
@optional
- (void)openFlowView:(AFOpenFlowView *)openFlowView click:(int)index;
- (void)openFlowView:(AFOpenFlowView *)openFlowView selectionDidChange:(int)index;
- (void)openFlowView:(AFOpenFlowView *)openFlowView click:(NSUInteger)index;
- (void)openFlowView:(AFOpenFlowView *)openFlowView selectionDidChange:(NSUInteger)index;
@end

@protocol AFOpenFlowViewDataSource <NSObject>
- (void)openFlowView:(AFOpenFlowView *)openFlowView requestImageForIndex:(int)index;
- (void)openFlowView:(AFOpenFlowView *)openFlowView requestImageForIndex:(NSUInteger)index;
- (UIImage *)defaultImage;
@end

Expand Down
94 changes: 47 additions & 47 deletions iphone/Classes/AFOpenFlow/AFOpenFlowView.m
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
@interface AFOpenFlowView (hidden)

- (void)setUpInitialState;
- (AFItemView *)coverForIndex:(int)coverIndex;
- (AFItemView *)coverForIndex:(NSUInteger)coverIndex;
- (void)updateCoverImage:(AFItemView *)aCover;
- (AFItemView *)dequeueReusableCover;
- (void)layoutCovers:(int)selected fromCover:(int)lowerBound toCover:(int)upperBound;
- (void)layoutCover:(AFItemView *)aCover selectedCover:(int)selectedIndex animated:(Boolean)animated;
- (void)layoutCovers:(NSUInteger)selected fromCover:(NSUInteger)lowerBound toCover:(NSUInteger)upperBound;
- (void)layoutCover:(AFItemView *)aCover selectedCover:(NSUInteger)selectedIndex animated:(Boolean)animated;
- (AFItemView *)findCoverOnscreen:(CALayer *)targetLayer;

@end
Expand Down Expand Up @@ -84,7 +84,7 @@ - (void)setUpInitialState {
[self updateLayout];
}

- (AFItemView *)coverForIndex:(int)coverIndex {
- (AFItemView *)coverForIndex:(NSUInteger)coverIndex {
AFItemView *coverView = [self dequeueReusableCover];
if (!coverView)
coverView = [[[AFItemView alloc] initWithFrame:CGRectZero] autorelease];
Expand All @@ -95,7 +95,7 @@ - (AFItemView *)coverForIndex:(int)coverIndex {
}

- (void)updateCoverImage:(AFItemView *)aCover {
NSNumber *coverNumber = [NSNumber numberWithInt:aCover.number];
NSNumber *coverNumber = [NSNumber numberWithUnsignedInteger:aCover.number];
UIImage *coverImage = (UIImage *)[coverImages objectForKey:coverNumber];
if (coverImage) {
NSNumber *coverImageHeightNumber = (NSNumber *)[coverImageHeights objectForKey:coverNumber];
Expand All @@ -121,8 +121,8 @@ - (AFItemView *)dequeueReusableCover {
return aCover;
}

- (void)layoutCover:(AFItemView *)aCover selectedCover:(int)selectedIndex animated:(Boolean)animated {
int coverNumber = aCover.number;
- (void)layoutCover:(AFItemView *)aCover selectedCover:(NSUInteger)selectedIndex animated:(Boolean)animated {
NSUInteger coverNumber = aCover.number;
CATransform3D newTransform;
CGPoint newPosition;

Expand Down Expand Up @@ -152,11 +152,11 @@ - (void)layoutCover:(AFItemView *)aCover selectedCover:(int)selectedIndex animat
}
}

- (void)layoutCovers:(int)selected fromCover:(int)lowerBound toCover:(int)upperBound {
- (void)layoutCovers:(NSUInteger)selected fromCover:(NSUInteger)lowerBound toCover:(NSUInteger)upperBound {
AFItemView *cover;
NSNumber *coverNumber;
for (int i = lowerBound; i <= upperBound; i++) {
coverNumber = [[NSNumber alloc] initWithInt:i];
for (NSUInteger i = lowerBound; i <= upperBound; i++) {
coverNumber = [[NSNumber alloc] initWithUnsignedLong:i];
cover = (AFItemView *)[onscreenCovers objectForKey:coverNumber];
[coverNumber release];
[self layoutCover:cover selectedCover:selected animated:YES];
Expand Down Expand Up @@ -213,8 +213,8 @@ - (void)updateLayout
halfScreenWidth = self.bounds.size.width / 2;
halfScreenHeight = self.bounds.size.height / 2;

int lowerBound = MAX(-1, selectedCoverView.number - COVER_BUFFER);
int upperBound = MIN(self.numberOfImages - 1, selectedCoverView.number + COVER_BUFFER);
NSUInteger lowerBound = MAX(-1, selectedCoverView.number - COVER_BUFFER);
NSUInteger upperBound = MIN(self.numberOfImages - 1, selectedCoverView.number + COVER_BUFFER);

[self layoutCovers:selectedCoverView.number fromCover:lowerBound toCover:upperBound];
[self centerOnSelectedCover:NO];
Expand All @@ -231,13 +231,13 @@ - (void)setBounds:(CGRect)newSize {
[self updateLayout];
}

- (void)setNumberOfImages:(int)newNumberOfImages {
- (void)setNumberOfImages:(NSUInteger)newNumberOfImages {

BOOL force = (newNumberOfImages != numberOfImages);
if (newNumberOfImages < numberOfImages) {
int current = newNumberOfImages;
NSUInteger current = newNumberOfImages;
while (current < numberOfImages) {
NSNumber *coverNumber = [NSNumber numberWithInt:current];
NSNumber *coverNumber = [NSNumber numberWithUnsignedInteger:current];
[coverImages removeObjectForKey:coverNumber];
[coverImageHeights removeObjectForKey:coverNumber];
current ++;
Expand All @@ -247,14 +247,14 @@ - (void)setNumberOfImages:(int)newNumberOfImages {
numberOfImages = newNumberOfImages;
scrollView.contentSize = CGSizeMake(newNumberOfImages * COVER_SPACING + self.bounds.size.width, self.bounds.size.height);

int lowerBound = MAX(0, selectedCoverView.number - COVER_BUFFER);
int upperBound = MIN(self.numberOfImages - 1, selectedCoverView.number + COVER_BUFFER);
NSUInteger lowerBound = MAX(0, selectedCoverView.number - COVER_BUFFER);
NSUInteger upperBound = MIN(self.numberOfImages - 1, selectedCoverView.number + COVER_BUFFER);

if (selectedCoverView) {
if (!force) {
[self layoutCovers:selectedCoverView.number fromCover:lowerBound toCover:upperBound];
} else {
int newSelected = (selectedCoverView.number < numberOfImages) ? selectedCoverView.number : (numberOfImages - 1);
NSUInteger newSelected = (selectedCoverView.number < numberOfImages) ? selectedCoverView.number : (numberOfImages - 1);
[self setSelectedCover:newSelected forceCalculation:YES];
}
}
Expand All @@ -274,16 +274,16 @@ - (void)setDefaultImage:(UIImage *)newDefaultImage {
}
}

- (void)setImage:(UIImage *)image forIndex:(int)index {
- (void)setImage:(UIImage *)image forIndex:(NSUInteger)index {
if (image==nil) return;
// Create a reflection for this image.
UIImage *imageWithReflection = AddImageReflection(image,kReflectionFraction);
NSNumber *coverNumber = [NSNumber numberWithInt:index];
NSNumber *coverNumber = [NSNumber numberWithUnsignedInteger:index];
[coverImages setObject:imageWithReflection forKey:coverNumber];
[coverImageHeights setObject:[NSNumber numberWithFloat:image.size.height] forKey:coverNumber];

// If this cover is onscreen, set its image and call layoutCover.
AFItemView *aCover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:index]];
AFItemView *aCover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:index]];
if (aCover) {
[aCover setImage:imageWithReflection originalImageHeight:image.size.height reflectionFraction:kReflectionFraction];
[self layoutCover:aCover selectedCover:selectedCoverView.number animated:NO];
Expand Down Expand Up @@ -361,32 +361,32 @@ - (void)centerOnSelectedCover:(BOOL)animated {
[scrollView setContentOffset:selectedOffset animated:animated];
}

- (void)setSelectedCover:(int)newSelectedCover {
- (void)setSelectedCover:(NSUInteger)newSelectedCover {
[self setSelectedCover:newSelectedCover forceCalculation:NO];
}

- (void)setSelectedCover:(int)newSelectedCover forceCalculation:(BOOL)force{
- (void)setSelectedCover:(NSUInteger)newSelectedCover forceCalculation:(BOOL)force{
if (!force && selectedCoverView && (newSelectedCover == selectedCoverView.number))
return;

AFItemView *cover;
int newLowerBound = MAX(0, newSelectedCover - COVER_BUFFER);
int newUpperBound = MIN(self.numberOfImages - 1, newSelectedCover + COVER_BUFFER);
NSUInteger newLowerBound = MAX(0, newSelectedCover - COVER_BUFFER);
NSUInteger newUpperBound = MIN(self.numberOfImages - 1, newSelectedCover + COVER_BUFFER);
if (!selectedCoverView || force) {
[offscreenCovers removeAllObjects];
[onscreenCovers removeAllObjects];
// Allocate and display covers from newLower to newUpper bounds.
for (int i=newLowerBound; i <= newUpperBound; i++) {
for (NSUInteger i=newLowerBound; i <= newUpperBound; i++) {
cover = [self coverForIndex:i];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithInt:i]];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithUnsignedInteger:i]];
[self updateCoverImage:cover];
[scrollView.layer addSublayer:cover.layer];
[self layoutCover:cover selectedCover:newSelectedCover animated:NO];
}

lowerVisibleCover = newLowerBound;
upperVisibleCover = newUpperBound;
selectedCoverView = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:newSelectedCover]];
selectedCoverView = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:newSelectedCover]];

return;
}
Expand All @@ -397,55 +397,55 @@ - (void)setSelectedCover:(int)newSelectedCover forceCalculation:(BOOL)force{
// This does not animate--assuming it's programmatically set from view controller.
// Recycle all onscreen covers.
AFItemView *cover;
for (int i = lowerVisibleCover; i <= upperVisibleCover; i++) {
cover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:i]];
for (NSUInteger i = lowerVisibleCover; i <= upperVisibleCover; i++) {
cover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:i]];
if (cover) {
[offscreenCovers addObject:cover];
[cover.layer removeFromSuperlayer];
[onscreenCovers removeObjectForKey:[NSNumber numberWithInt:cover.number]];
[onscreenCovers removeObjectForKey:[NSNumber numberWithUnsignedInteger:cover.number]];
}
}

// Move all available covers to new location.
for (int i=newLowerBound; i <= newUpperBound; i++) {
for (NSUInteger i=newLowerBound; i <= newUpperBound; i++) {
cover = [self coverForIndex:i];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithInt:i]];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithUnsignedInteger:i]];
[self updateCoverImage:cover];
[scrollView.layer addSublayer:cover.layer];
}

lowerVisibleCover = newLowerBound;
upperVisibleCover = newUpperBound;
selectedCoverView = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:newSelectedCover]];
selectedCoverView = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:newSelectedCover]];
[self layoutCovers:newSelectedCover fromCover:newLowerBound toCover:newUpperBound];

return;
} else if (newSelectedCover > selectedCoverView.number) {
// Move covers that are now out of range on the left to the right side,
// but only if appropriate (within the range set by newUpperBound).
for (int i=lowerVisibleCover; i < newLowerBound; i++) {
cover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:i]];
for (NSUInteger i=lowerVisibleCover; i < newLowerBound; i++) {
cover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:i]];
if (upperVisibleCover < newUpperBound) {
// Tack it on the right side.
upperVisibleCover++;
cover.number = upperVisibleCover;
[self updateCoverImage:cover];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithInt:cover.number]];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithUnsignedInteger:cover.number]];
[self layoutCover:cover selectedCover:newSelectedCover animated:NO];
} else {
if (cover) {
[offscreenCovers addObject:cover];
[cover.layer removeFromSuperlayer];
}
}
[onscreenCovers removeObjectForKey:[NSNumber numberWithInt:i]];
[onscreenCovers removeObjectForKey:[NSNumber numberWithUnsignedInteger:i]];
}
lowerVisibleCover = newLowerBound;

// Add in any missing covers on the right up to the newUpperBound.
for (int i=upperVisibleCover + 1; i <= newUpperBound; i++) {
for (NSUInteger i=upperVisibleCover + 1; i <= newUpperBound; i++) {
cover = [self coverForIndex:i];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithInt:i]];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithUnsignedInteger:i]];
[self updateCoverImage:cover];
[scrollView.layer addSublayer:cover.layer];
[self layoutCover:cover selectedCover:newSelectedCover animated:NO];
Expand All @@ -454,14 +454,14 @@ - (void)setSelectedCover:(int)newSelectedCover forceCalculation:(BOOL)force{
} else {
// Move covers that are now out of range on the right to the left side,
// but only if appropriate (within the range set by newLowerBound).
for (int i=upperVisibleCover; i > newUpperBound; i--) {
cover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:i]];
for (NSUInteger i=upperVisibleCover; i > newUpperBound; i--) {
cover = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:i]];
if (lowerVisibleCover > newLowerBound) {
// Tack it on the left side.
lowerVisibleCover --;
cover.number = lowerVisibleCover;
[self updateCoverImage:cover];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithInt:lowerVisibleCover]];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithUnsignedInteger:lowerVisibleCover]];
[self layoutCover:cover selectedCover:newSelectedCover animated:NO];
} else {
// Recycle this cover.
Expand All @@ -470,14 +470,14 @@ - (void)setSelectedCover:(int)newSelectedCover forceCalculation:(BOOL)force{
[cover.layer removeFromSuperlayer];
}
}
[onscreenCovers removeObjectForKey:[NSNumber numberWithInt:i]];
[onscreenCovers removeObjectForKey:[NSNumber numberWithUnsignedInteger:i]];
}
upperVisibleCover = newUpperBound;

// Add in any missing covers on the left down to the newLowerBound.
for (int i=lowerVisibleCover - 1; i >= newLowerBound; i--) {
for (NSUInteger i=lowerVisibleCover - 1; i >= newLowerBound; i--) {
cover = [self coverForIndex:i];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithInt:i]];
[onscreenCovers setObject:cover forKey:[NSNumber numberWithUnsignedInteger:i]];
[self updateCoverImage:cover];
[scrollView.layer addSublayer:cover.layer];
[self layoutCover:cover selectedCover:newSelectedCover animated:NO];
Expand All @@ -490,7 +490,7 @@ - (void)setSelectedCover:(int)newSelectedCover forceCalculation:(BOOL)force{
else if (newSelectedCover > selectedCoverView.number)
[self layoutCovers:newSelectedCover fromCover:selectedCoverView.number toCover:newSelectedCover];

selectedCoverView = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithInt:newSelectedCover]];
selectedCoverView = (AFItemView *)[onscreenCovers objectForKey:[NSNumber numberWithUnsignedInteger:newSelectedCover]];
}

-(void)layoutSubviews
Expand Down
3 changes: 1 addition & 2 deletions iphone/Classes/APIModule.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ -(NSString*)apiName

-(void)logMessage:(NSArray*)args severity:(NSString*)severity
{
NSMutableString* message = [NSMutableString string];

NSString* lcSeverity = [severity lowercaseString];
#ifdef TI_DEBUGGER_PROFILER
NSString* lcSeverity = [severity lowercaseString];
DebuggerLogLevel level = OUT;
if ([lcSeverity isEqualToString:@"warn"]) {
level = WARN;
Expand Down
2 changes: 1 addition & 1 deletion iphone/Classes/AudioStreamer/AudioStreamer.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ extern NSString * const ASStatusChangedNotification;
@property (readwrite) UInt32 bitRate;
@property (readwrite) double volume;
@property (readwrite,assign) id<AudioStreamerDelegate> delegate;
@property (nonatomic,readwrite,assign) NSUInteger bufferSize;
@property (nonatomic,readwrite,assign) UInt32 bufferSize;

- (void)start;
- (void)stop;
Expand Down
4 changes: 2 additions & 2 deletions iphone/Classes/AudioStreamer/AudioStreamer.m
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,14 @@ -(void)func\
// Properties
RUN_ON_STREAMER_SET(setErrorCode,AudioStreamerErrorCode)
RUN_ON_STREAMER_SET(setBitRate,UInt32)
RUN_ON_STREAMER_SET(setBufferSize, NSUInteger)
RUN_ON_STREAMER_SET(setBufferSize, UInt32)
RUN_ON_STREAMER_SET(setVolume, double)

RUN_ON_STREAMER_RETURN(errorCode, AudioStreamerErrorCode)
RUN_ON_STREAMER_RETURN(bitRate, UInt32)
RUN_ON_STREAMER_RETURN(state, AudioStreamerState)
RUN_ON_STREAMER_RETURN(progress, double)
RUN_ON_STREAMER_RETURN(bufferSize, NSUInteger)
RUN_ON_STREAMER_RETURN(bufferSize, UInt32)
RUN_ON_STREAMER_RETURN(volume, double)
RUN_ON_STREAMER_RETURN(duration, NSTimeInterval);

Expand Down