New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-14123] Android: Add support for creating video thumbnails #6393
Conversation
Jira Ticket: https://jira.appcelerator.org/browse/TIMOB-14123 |
Sample Code:
|
To test using a test mp4 file, put it in "assets/Resources" folder. |
@@ -0,0 +1,57 @@ | |||
package ti.modules.titanium.media; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this class? I think the only thing we do here is to track if the dataSource is set or not, since we are internally setting the datasource, can't we check there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. Removing this.
New sample app.js code that includes showing the video player since video player code has changed. Change is due to sharing a helper class with thumbnail code.
|
Latest changes looks good, I don't see any issues. |
import android.net.Uri; | ||
import android.os.Build; | ||
|
||
public class TiDataSourceHelper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering why can't this be an inner class instead of a separate file by itself? It could also be a method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TiVideoView8 and TiThumbnailRetriever uses the same method. Hence I placed it there. Is there a better way to do this?
It originally was code that was in both files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you try adding it as a static method in TiUIHelper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll try it with that.
Attention: The contributor has signed the CLA |
Attention: The contributor has signed the CLA |
Code reviewed and functionally tested. Request accepted |
[TIMOB-14123] Android: Add support for creating video thumbnails
The function requestThumbnailImagesAtTimes is still undefined in SDK 3.5.0.GA on Android - Any idea when it'll be included or where I can track the progress for GA? Edit: Nevermind, found it in Jira - it's coming in 3.6.0! |
No description provided.