[TIMOB-19163] Android: Removal of Apache HTTP Client #7036
Conversation
… use -In preparation of Apache's HTTPClient being removed in Android M -GET and POST available -SSL in use
-Changed replaced HTTPClientProxy and TiHTTPClient with HttpURLConnectionProxy and TiHttpURLConnection -Renamed the proxy back to HTTPClientProxy and TiHTTPClient -Changed CookieProxy to use Java instead of Apache -Progress listener added to outputstream -Added Password and Username usage -addAuthFactory method is not available for the new HttpClient
|
Jira:- https://jira.appcelerator.org/browse/TIMOB-19163 Note: Refer to jira for method to test this. |
| setProperty(TiC.PROPERTY_DOMAIN, httpCookie.getDomain()); | ||
| // PROPERTY_EXPIRY_DATE not used instead, PROPERTY_MAX_AGE is used | ||
| // See http://developer.android.com/reference/java/net/HttpCookie.html for more info | ||
| setProperty(TiC.PROPERTY_MAX_AGE, httpCookie.getMaxAge()); |
There was a problem hiding this comment.
Did you modify the doc for this replacement property?
There was a problem hiding this comment.
Will modify the docs.
…n to use HttpURLConnection -Updated ImageView Doc due to changes in TiDrawableReference
|
Ash, excellent work on this PR! Initial code review looks good, just one thing: I don't see any removal of Apache libraries (the jar itself). We should probably do that, along with updating the build scripts to remove any apache related libraries. |
|
I've ran your test app, and ran into a few problems:
|
|
Okay. I'll update the tests. |
|
Regression:
|
|
@hieupham007 Will work on those 2 working. Thanks for finding those! |
…dated when page redirects
|
Fixed Regressions for:
Check JIRA for updated test case for these 2. |
|
Code reviewed and tested with KS, the test case in the ticket, and these tickets: Request accepted. |
[TIMOB-19163] Android: Removal of Apache HTTP Client
|
Thank you. |
-Implemented HttpURLConnection for Android M to use