[TIMOB-19578] Material design custom animations - touch feedback #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Touch feedback is applied only if the backgroundColor is a solid color. | ||
| type: Boolean | ||
| default: false | ||
| platforms: [android] |
There was a problem hiding this comment.
missing since: "5.2.0"
… code review changes to docs.
|
Please update with master and resolve conflicts |
[TIMOB-19667] Remove Warning
|
Updated with master and resolved conflicts. |
| */ | ||
| private void applyTouchFeedback(@NonNull Integer bgColor, @Nullable Integer rippleColor) { | ||
| Context appContext = TiApplication.getInstance(); | ||
| if (rippleColor == null) { |
There was a problem hiding this comment.
looks like some indentation issue?
There was a problem hiding this comment.
Addressed indentation issue. Please review.
…xed indentation issues
|
@sriks @hieupham007 Can we merge this as all comments are addressed? |
|
@sriks @ashcoding Ping. We should change the docs |
|
Closing in favor of #8176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA https://jira.appcelerator.org/browse/TIMOB-19578