-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-19578] Material design custom animations - touch feedback #7317
Conversation
Touch feedback is applied only if the backgroundColor is a solid color. | ||
type: Boolean | ||
default: false | ||
platforms: [android] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing since: "5.2.0"
… code review changes to docs.
Please update with master and resolve conflicts |
[TIMOB-19667] Remove Warning
Updated with master and resolved conflicts. |
*/ | ||
private void applyTouchFeedback(@NonNull Integer bgColor, @Nullable Integer rippleColor) { | ||
Context appContext = TiApplication.getInstance(); | ||
if (rippleColor == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some indentation issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed indentation issue. Please review.
…xed indentation issues
@sriks @hieupham007 Can we merge this as all comments are addressed? |
@sriks @ashcoding Ping. We should change the docs |
Closing in favor of #8176. |
JIRA https://jira.appcelerator.org/browse/TIMOB-19578