Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-19829] iOS: Added trackTintColor #7373

Merged
merged 1 commit into from Nov 2, 2015
Merged

[TIMOB-19829] iOS: Added trackTintColor #7373

merged 1 commit into from Nov 2, 2015

Conversation

kopiro
Copy link
Contributor

@kopiro kopiro commented Oct 29, 2015

Expose setProgressTintColor and setTrackTintColor in the ProgressBar in iOS.

https://jira.appcelerator.org/browse/TIMOB-19829

@kopiro kopiro changed the title Added progressTintColor and trackTintColor [TC-5747] Added progressTintColor and trackTintColor Oct 29, 2015
@hansemannn
Copy link
Collaborator

Hi @kopiro , thank you for the PR! Before we merge, please address the following issues:

  • Provide a documentation (in apidocs/Titanium/UI/ProgressBar.yml)
  • Provide sample code to show your changes.
  • You removed lines (can be seen red in the diff), please restore them so that only new lines are highlighted.

The rest looks fine!

@hansemannn hansemannn changed the title [TC-5747] Added progressTintColor and trackTintColor [TC-5747] iOS: Added progressTintColor and trackTintColor Oct 29, 2015
@kopiro
Copy link
Contributor Author

kopiro commented Oct 29, 2015

@hansemannn is it ok now?
Where should i provide code sample? They're just properties.

hansemannn
hansemannn reviewed Oct 29, 2015
View reviewed changes
apidoc/Titanium/UI/ProgressBar.yml
summary: The color shown for the portion of the progress bar that is not filled.
type: String
platforms: [iphone, ipad]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the line since: "5.2.0" on both properties to let our users know since which SDK version the properties will be available. Then we're good to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@hansemannn
Copy link
Collaborator

As discussed, we need only trackTintColor as progressTintColor is already is covered in the SDK using the tintColor propery. @kopiro OK? Would merge this asap after the last correction. Thanks!

@kopiro
Copy link
Contributor Author

kopiro commented Nov 2, 2015

@hansemannn done!

@kopiro kopiro changed the title [TC-5747] iOS: Added progressTintColor and trackTintColor [TC-5747] iOS: Added trackTintColor Nov 2, 2015
@hansemannn
Copy link
Collaborator

CR + FT passed, merging PR. Thank you @kopiro !

@hansemannn hansemannn changed the title [TC-5747] iOS: Added trackTintColor [TIMOB-19829] iOS: Added trackTintColor Nov 2, 2015
hansemannn added a commit that referenced this pull request Nov 2, 2015
@hansemannn
Merge pull request #7373 from kopiro/pr-TC-5747
2fc803f 
[TIMOB-19829] iOS: Added trackTintColor
@hansemannn hansemannn merged commit 2fc803f into tidev:master Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kopiro @hansemannn