Upgrade build scripts to set proper deployment version for 1.8. #760
Conversation
| @@ -1128,9 +1128,6 @@ def main(args): | |||
| # Meet the minimum requirements for ipad when necessary | |||
| if devicefamily == 'ipad' or devicefamily == 'universal': | |||
| device_target="TARGETED_DEVICE_FAMILY=2" | |||
| # iPad requires at a minimum 3.2 (not 3.1 default) | |||
| if devicefamily == 'ipad': | |||
| deploy_target = "IPHONEOS_DEPLOYMENT_TARGET=3.2" | |||
| # NOTE: this is very important to run on device -- i dunno why | |||
There was a problem hiding this comment.
Does this comment need to stay around?
There was a problem hiding this comment.
Actually a leadin to the following comment. ipad shouldn't require armv6, but there were complaints by the system when those symbols weren't included before. This actually requires research outside the scope of just changing the minimum versioning.
We should probably also be separating out the i386, armv6, and armv7 versions of libTiCore (and debugger) to avoid bloat in distributed apps where possible but this is a separate issue as well.
There was a problem hiding this comment.
Added ticket 6292 to track armv6 issues.
|
Functionally tested and APPROVED Tested on iPhone 3GS running 3.1.2 and iPhone4 running 5.0.1 with normal iOS build... WAITING FOR ERIC TO REVALIDATED IT |
|
Pull accepted: The other two devices installed as expected, and launched and functioned correctly. These devices were iPhone 4s (5.0.1) and iPod 3rd Gen (4.0.1). |
|
Code reviewed. Accepted with comments and additional tickets. |
[TIMOB-6317] Upgrade build scripts to set proper deployment version for 1.8.
The project was updated to build for minimum SDK 4.0, but the build scripts (which override this setting) were not updated.